You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/08/25 11:20:43 UTC
[GitHub] [kylin] hit-lacus opened a new pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
hit-lacus opened a new pull request #1734:
URL: https://github.com/apache/kylin/pull/1734
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :
1. The original branch _kylin-on-parquet-v2_ for **Kylin 4.X** (Parquet Storage) has been renamed to branch **main**, and configured as the **default** branch;
2. The original branch _master_ for **Kylin 3.X** (HBase Storage) has been renamed to branch **kylin3** ;
Please check [Intro to Kylin 4 architecture](https://kylin.apache.org/blog/2021/07/02/Apache-Kylin4-A-new-storage-and-compute-architecture/) and [INFRA-22166](https://issues.apache.org/jira/browse/INFRA-22166) if you are interested.
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation (if appropriate)
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905502018
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`main@a7b7edb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage ? 24.64%
Complexity ? 4449
=======================================
Files ? 1092
Lines ? 61940
Branches ? 8903
=======================================
Hits ? 15265
Misses ? 45062
Partials ? 1613
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a7b7edb...ad989cc](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905439942
### 分析 on Kylin 2.2
当我们创建 Model ，选择 “Add Lookup Table”，有一个勾选“Skip snapshot for this lookup table”，并且默认不勾选。当勾选时，Model 的元数据中，该维度表的 type 字段的值为“FACT”，反之为“LOOKUP”。
```sql
-- Q1
-- Group by 同时包含事实表和维度表的列
select ACCOUNT_CONTACT, COUNTRY, count(*)
from KYLIN_ACCOUNT left join KYLIN_COUNTRY
on KYLIN_ACCOUNT.ACCOUNT_COUNTRY = KYLIN_COUNTRY.country
group by ACCOUNT_CONTACT, COUNTRY
-- Q2
-- Group by 只包含维度表的列
select COUNTRY, count(*)
from KYLIN_COUNTRY
group by COUNTRY
```
### 验证
1. Cube1：维度表设置为 FACT，维度表的列（只）可以设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → failed
2. Cube2：维度表设置为 LOOKUP，维度表的列全部设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → snapshot
3. Cube3：维度表设置为 LOOKUP，维度表的列全部设置为 Derived
1. Q1 → cuboid = 3(011, 一个更便宜的 cuboid)
2. Q2 → snapshot
### 总结
- 是否构建维度表快照是由，定义模型时是否勾选“Skip snapshot for this lookup table”决定，勾选后不构建快照，并且无法回答维度表的查询
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905439942
### 分析
当我们创建 Model ，选择 “Add Lookup Table”，有一个勾选“Skip snapshot for this lookup table”，并且默认不勾选。当勾选时，Model 的元数据中，该维度表的 type 字段的值为“FACT”，反之为“FACT”。
```sql
-- Q1
-- Group by 同时包含事实表和维度表的列
select ACCOUNT_CONTACT, COUNTRY, count(*)
from KYLIN_ACCOUNT left join KYLIN_COUNTRY
on KYLIN_ACCOUNT.ACCOUNT_COUNTRY = KYLIN_COUNTRY.country
group by ACCOUNT_CONTACT, COUNTRY
-- Q2
-- Group by 只包含维度表的列
select COUNTRY, count(*)
from KYLIN_COUNTRY
group by COUNTRY
```
### 验证
1. Cube1：维度表设置为 FACT，维度表的列（只）可以设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → failed
2. Cube2：维度表设置为 LOOKUP，维度表的列全部设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → snapshot
3. Cube3：维度表设置为 LOOKUP，维度表的列全部设置为 Derived
1. Q1 → cuboid = 3(011, 一个更便宜的 cuboid)
2. Q2 → snapshot
### 总结
- 是否构建维度表快照是由，定义模型时是否勾选“Skip snapshot for this lookup table”决定，勾选后不构建快照，并且无法回答维度表的查询
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus merged pull request #1734:
URL: https://github.com/apache/kylin/pull/1734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus commented on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus commented on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905441825
### 测试
- Before failed
- After
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905441825
### 构建测试
- Before -> Failed
- After -> Succeed
### 查询测试
- After
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus edited a comment on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
hit-lacus edited a comment on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905439942
### 分析 on Kylin 2.2
当我们创建 Model ，选择 “Add Lookup Table”，有一个勾选“Skip snapshot for this lookup table”，并且默认不勾选。当勾选时，Model 的元数据中，该维度表的 type 字段的值为“FACT”，反之为“FACT”。
```sql
-- Q1
-- Group by 同时包含事实表和维度表的列
select ACCOUNT_CONTACT, COUNTRY, count(*)
from KYLIN_ACCOUNT left join KYLIN_COUNTRY
on KYLIN_ACCOUNT.ACCOUNT_COUNTRY = KYLIN_COUNTRY.country
group by ACCOUNT_CONTACT, COUNTRY
-- Q2
-- Group by 只包含维度表的列
select COUNTRY, count(*)
from KYLIN_COUNTRY
group by COUNTRY
```
### 验证
1. Cube1：维度表设置为 FACT，维度表的列（只）可以设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → failed
2. Cube2：维度表设置为 LOOKUP，维度表的列全部设置为 Normal
1. Q1 → cuboid = 6(00110)
2. Q2 → snapshot
3. Cube3：维度表设置为 LOOKUP，维度表的列全部设置为 Derived
1. Q1 → cuboid = 3(011, 一个更便宜的 cuboid)
2. Q2 → snapshot
### 总结
- 是否构建维度表快照是由，定义模型时是否勾选“Skip snapshot for this lookup table”决定，勾选后不构建快照，并且无法回答维度表的查询
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter edited a comment on pull request #1734: KYLIN-5067 Skip snapshot build when dimension table's kind is LOOKUP
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1734:
URL: https://github.com/apache/kylin/pull/1734#issuecomment-905502018
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`main@a7b7edb`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1734 +/- ##
=======================================
Coverage ? 24.64%
Complexity ? 4450
=======================================
Files ? 1092
Lines ? 61941
Branches ? 8903
=======================================
Hits ? 15265
Misses ? 45063
Partials ? 1613
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a7b7edb...1c15cc5](https://codecov.io/gh/apache/kylin/pull/1734?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org