You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "zhaoyuguang (GitHub)" <gi...@apache.org> on 2019/01/11 09:52:02 UTC
[GitHub] [incubator-dubbo] zhaoyuguang opened pull request #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
## What is the purpose of the change
some printStackTrace() forgot use logger to replace
## Brief changelog
such as
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zhaoyuguang commented on issue #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
Posted by "zhaoyuguang (GitHub)" <gi...@apache.org>.
> Nice work!
> Thanks for your pr, I suggest that the optimization code can be placed in a pr.
I am also a rookie.
I don't know which ones are needed for dubbo.
so pr as needed maybe better.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] CrazyHZM commented on issue #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
Posted by "CrazyHZM (GitHub)" <gi...@apache.org>.
Nice work!
Thanks for your pr, I suggest that the optimization code can be placed in a pr.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 closed pull request #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] zhaoyuguang commented on issue #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
Posted by "zhaoyuguang (GitHub)" <gi...@apache.org>.
> Nice work!
> Thanks for your pr, I suggest that the optimization code can be placed in a pr.
I am also a rookie.
I don't know which ones are needed for dubbo.
so pr as needed maybe better.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3202:
Optimize the code: some printStackTrace() forgot use logger to replace
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=h1) Report
> Merging [#3202](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/5298afdf401185876edd49b0ad5755f8f618e4cb?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `14.28%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3202 +/- ##
============================================
+ Coverage 63.62% 63.64% +0.01%
Complexity 75 75
============================================
Files 652 652
Lines 28200 28202 +2
Branches 4781 4781
============================================
+ Hits 17943 17949 +6
+ Misses 7995 7990 -5
- Partials 2262 2263 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...src/main/java/org/apache/dubbo/container/Main.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9NYWluLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/transport/netty4/logging/MessageFormatter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L2xvZ2dpbmcvTWVzc2FnZUZvcm1hdHRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/common/utils/PojoUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvUG9qb1V0aWxzLmphdmE=) | `71.3% <20%> (-0.13%)` | `0 <0> (ø)` | |
| [...ava/org/apache/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9EdWJib1NodXRkb3duSG9vay5qYXZh) | `78.12% <0%> (-6.25%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-3.28%)` | `0% <0%> (ø)` | |
| [...pache/dubbo/registry/support/AbstractRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L0Fic3RyYWN0UmVnaXN0cnkuamF2YQ==) | `79.61% <0%> (-1.16%)` | `0% <0%> (ø)` | |
| [.../apache/dubbo/remoting/transport/AbstractPeer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RQZWVyLmphdmE=) | `63.04% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../java/org/apache/dubbo/config/ReferenceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9SZWZlcmVuY2VDb25maWcuamF2YQ==) | `58.86% <0%> (+0.37%)` | `0% <0%> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `86.2% <0%> (+3.44%)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3202/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=footer). Last update [5298afd...010b7b1](https://codecov.io/gh/apache/incubator-dubbo/pull/3202?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3202 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org