You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by bogdanalbei <gi...@git.apache.org> on 2014/09/04 16:36:58 UTC
[GitHub] thrift pull request: Update TForkingServer.php
GitHub user bogdanalbei opened a pull request:
https://github.com/apache/thrift/pull/208
Update TForkingServer.php
The while() statement was causing the forked children to handle one request and then just spin without doing anything. By connecting to the server multiple times, you would end up with lots of children processes that wouldn't exit, but consume processor time.
The fix is to handle one request per child and then exit.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bogdanalbei/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #208
----
commit 90ef5fad16b88857830bb87777ee1c8e53e07e5f
Author: Bogdan Albei <bo...@gmail.com>
Date: 2014-09-04T14:32:00Z
Update TForkingServer.php
fixed endless loop, one child should handle one request.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: Update TForkingServer.php
Posted by bogdanalbei <gi...@git.apache.org>.
Github user bogdanalbei closed the pull request at:
https://github.com/apache/thrift/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---