You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/06/19 17:34:06 UTC
[GitHub] incubator-brooklyn pull request: sensors at riak cluster level and...
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/701
sensors at riak cluster level and other minor tidies for riak and couchbase
@bostko hi can you review this?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn riak-cluster-sensors
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/701.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #701
----
commit 33f1e49e5919ce58f600336f9929947be2778e7d
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-06-19T15:31:19Z
sensors at riak cluster level and other minor tidies for riak and couchbase
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: sensors at riak cluster level and...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/701#discussion_r32873086
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/riak/RiakClusterImpl.java ---
@@ -112,6 +122,38 @@ public URI apply(Collection<URI> input) {
.fromMembers()
.build();
addEnricher(first);
+
+ Map<? extends AttributeSensor<? extends Number>, ? extends AttributeSensor<? extends Number>> enricherSetup =
+ ImmutableMap.<AttributeSensor<? extends Number>, AttributeSensor<? extends Number>>builder()
+ .put(RiakNode.NODE_PUTS, RiakCluster.NODE_PUTS_1MIN_PER_NODE)
--- End diff --
Would be good if the Riak cluster tests were updated to assert that the `NODE_PUTS_1MIN_PER_NODE` etc are being populated (e.g. that the attribute is eventually non-null).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: sensors at riak cluster level and...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/701
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: sensors at riak cluster level and...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/701#issuecomment-113655788
Looks good; would be nice to improve our test coverage for things like this (even if it is just that the attribute values are non-null). Merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: sensors at riak cluster level and...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/701#issuecomment-113613328
Very good changes, thank you!
I tested the cluster avarage values with https://github.com/apache/incubator-brooklyn/blob/master/examples/simple-web-cluster/src/main/resources/brooklyn/demo/nodejs-riak-todo.yaml and it looks good
P.S. I think it would be better if changes in doStart and those for cluster stats were in separate commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---