You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/04/04 17:35:48 UTC

[GitHub] [helix] mgao0 commented on a diff in pull request #2005: Populate helix cloud property using cloud config

mgao0 commented on code in PR #2005:
URL: https://github.com/apache/helix/pull/2005#discussion_r841986121


##########
helix-core/src/main/java/org/apache/helix/model/CloudConfig.java:
##########
@@ -94,6 +94,10 @@ public CloudConfig(String cluster, boolean enabled, CloudProvider cloudProvider,
     }
   }
 
+  public static CloudConfig buildEmptyCloudConfig() {

Review Comment:
   Good point. Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org