[GitHub] [kafka] rondagostino commented on a change in pull request #11256: KAFKA-13224: Expose consistent broker.id and node.id in config values/originals maps

[GitBox <gi...@apache.org>]

rondagostino commented on a change in pull request #11256:
URL: https://github.com/apache/kafka/pull/11256#discussion_r695176785



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1405,21 +1405,95 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolean, dynamicConfigO
   // We make it part of each instance rather than the object to facilitate testing.
   private val zkClientConfigViaSystemProperties = new ZKClientConfig()
 
-  override def originals: util.Map[String, AnyRef] =
-    if (this eq currentConfig) super.originals else currentConfig.originals
+  private def maybeMutateOriginalsToMakeBrokerIdAndNodeIdMatch(map: util.Map[String, AnyRef]): util.Map[String, AnyRef] = {

Review comment:
       This is pretty much the same as `maybeMutateOriginalsStringsToMakeBrokerIdAndNodeIdMatch()` below, but I was unable to consolidate them into a single method due to type-related errors.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org