You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/18 06:59:13 UTC

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22253: Support select group by statement when column contains null values

codecov-commenter commented on PR #22253:
URL: https://github.com/apache/shardingsphere/pull/22253#issuecomment-1319621350

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22253?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22253](https://codecov.io/gh/apache/shardingsphere/pull/22253?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b14c86) into [master](https://codecov.io/gh/apache/shardingsphere/commit/83cad1c89621509ad36fbb5fce7f251254b419ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83cad1c) will **increase** coverage by `0.00%`.
   > The diff coverage is `65.27%`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #22253   +/-   ##
   =========================================
     Coverage     60.88%   60.88%           
     Complexity     2552     2552           
   =========================================
     Files          4165     4166    +1     
     Lines         57621    57636   +15     
     Branches       9755     9772   +17     
   =========================================
   + Hits          35081    35091   +10     
   + Misses        19580    19579    -1     
   - Partials       2960     2966    +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22253?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvbWVyZ2UvZHFsL1NoYXJkaW5nRFFMUmVzdWx0TWVyZ2VyLmphdmE=) | `75.00% <0.00%> (-1.75%)` | :arrow_down: |
   | [...arser/sql/common/constant/NullsOrderDirection.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9jb25zdGFudC9OdWxsc09yZGVyRGlyZWN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...gment/dml/order/item/ColumnOrderByItemSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RtbC9vcmRlci9pdGVtL0NvbHVtbk9yZGVyQnlJdGVtU2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...t/dml/order/item/ExpressionOrderByItemSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RtbC9vcmRlci9pdGVtL0V4cHJlc3Npb25PcmRlckJ5SXRlbVNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...egment/dml/order/item/IndexOrderByItemSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RtbC9vcmRlci9pdGVtL0luZGV4T3JkZXJCeUl0ZW1TZWdtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...segment/dml/order/item/TextOrderByItemSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9zdGF0ZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvc3FsL2NvbW1vbi9zZWdtZW50L2RtbC9vcmRlci9pdGVtL1RleHRPcmRlckJ5SXRlbVNlZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...nal/asserts/segment/orderby/OrderByItemAssert.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9wYXJzZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3Rlc3Qvc3FsL3BhcnNlci9pbnRlcm5hbC9hc3NlcnRzL3NlZ21lbnQvb3JkZXJieS9PcmRlckJ5SXRlbUFzc2VydC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...oken/generator/impl/ProjectionsTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvc2hhcmRpbmcvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvaW1wbC9Qcm9qZWN0aW9uc1Rva2VuR2VuZXJhdG9yLmphdmE=) | `71.69% <50.00%> (-4.31%)` | :arrow_down: |
   | [...nt/select/orderby/engine/OrderByContextEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvYmluZGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9iaW5kZXIvc2VnbWVudC9zZWxlY3Qvb3JkZXJieS9lbmdpbmUvT3JkZXJCeUNvbnRleHRFbmdpbmUuamF2YQ==) | `85.71% <66.66%> (-2.75%)` | :arrow_down: |
   | [...r/statement/impl/OpenGaussStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9kaWFsZWN0L29wZW5nYXVzcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9vcGVuZ2F1c3MvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9PcGVuR2F1c3NTdGF0ZW1lbnRTUUxWaXNpdG9yLmphdmE=) | `85.46% <66.66%> (-0.24%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/shardingsphere/pull/22253/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org