You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by "mreutegg (via GitHub)" <gi...@apache.org> on 2023/04/17 18:42:12 UTC

[GitHub] [jackrabbit-oak] mreutegg commented on a diff in pull request #900: OAK-10192: switch oak-query-spi to shaded guava

mreutegg commented on code in PR #900:
URL: https://github.com/apache/jackrabbit-oak/pull/900#discussion_r1169136216


##########
oak-query-spi/pom.xml:
##########
@@ -39,7 +39,6 @@
           <configuration>
             <instructions>
               <Import-Package>
-                <!-- OAK-7182 -->${guava.osgi.import},

Review Comment:
   I think the entire Import-Package instruction can be removed. Importing everything that is required is the [default behavior](https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_default_behavior).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org