[GitHub] [hbase] Apache9 commented on a change in pull request #3601: HBASE-26180 Introduce a initial refresh interval for RpcConnectionReg…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #3601:
URL: https://github.com/apache/hbase/pull/3601#discussion_r694444548



##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RegistryEndpointsRefresher.java
##########
@@ -60,9 +63,20 @@ public synchronized void stop() {
     notifyAll();
   }
 
+  private long getRefreshIntervalMs(boolean firstRefresh) {
+    if (refreshNow) {
+      return minTimeBetweenRefreshesMs;
+    }
+    if (firstRefresh) {

Review comment:
       I think jitter is used to solve another problem? It is always good to add a jitter to periodically requests to reduce the possibility to request at the same time.
   
   For the purpose of this issue, let me just paste the description here first to see it can help you to understand better
   
   > Introduce a initial refresh interval for RpcConnectionRegistry  so we can get the new list soon once we connect to the cluster.
   As end users could configure any nodes in a cluster as the initial bootstrap nodes, it is possible that different end users will configure the same machine which makes the machine over load. So we should have a shorter delay for the initial refresh, to let users quickly switch to the bootstrap nodes we want them to connect to.
   
   Free feel to ask if you have other concerns.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org