[jira] [Commented] (CB-5191) Deprecate

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803663#comment-13803663 ] 

ASF subversion and git services commented on CB-5191:
-----------------------------------------------------

Commit 4437d7f3c45a56dd4014d79f414c6ee492f29b6f in branch refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=4437d7f ]

CB-5191 Deprecate <url-filter>


> Deprecate <url-filter>
> ----------------------
>
>                 Key: CB-5191
>                 URL: https://issues.apache.org/jira/browse/CB-5191
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>
> For the onOverrideUrlLoading() function to be called on a plugin, it must have a <url-filter> in it's <feature> tag. 
> This is an undocumented quirk, and I don't think it has any benefit. In order not to break existing plugins that rely on it though, I'm going to:
> 1. If a plugin does have a url-filter, show a deprecation message and still apply the filtering before calling its onOverrideUrlLoading() function.
> 2. If a plugin does not have a url-filter, then always call its onOverrideUrlLoading() function.



--
This message was sent by Atlassian JIRA
(v6.1#6144)