[jira] [Commented] (BEAM-1230) Typo in the documentation of the Window class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-1230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15785534#comment-15785534 ] 

ASF GitHub Bot commented on BEAM-1230:
--------------------------------------

GitHub user staslev opened a pull request:

    https://github.com/apache/beam/pull/1716

    [BEAM-1230] Fixed a typo in the documentation of the Window class.

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    R: @dhalperi , I think we're pretty much the only ones not on a vacation at the moment...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/staslev/incubator-beam BEAM-1230-Typo-in-the-documentation-of-the-Window-class

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1716.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1716
    
----
commit 1cc0dcbe58e3ea52bdcb183322efdf63ff96961e
Author: Stas Levin <st...@gmail.com>
Date:   2016-12-29T15:30:37Z

    [BEAM-1230] Fixed a typo in the documentation of the Window class.

----


> Typo in the documentation of the Window class
> ---------------------------------------------
>
>                 Key: BEAM-1230
>                 URL: https://issues.apache.org/jira/browse/BEAM-1230
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Stas Levin
>            Assignee: Stas Levin
>            Priority: Trivial
>
> {code}
>  * <pre>{@code
>  * PCollection<String> windowed_items = items.apply(
>  *   Window.<String>into(FixedWindows.of(Duration.standardMinutes(1))
>  *      .triggering(
>  *      .triggering(
>  *          AfterWatermark.pastEndOfWindow()
>  *              .withEarlyFirings(AfterProcessingTime
>  *                  .pastFirstElementInPane().plusDelayOf(Duration.standardMinutes(1))))
>  *      .withAllowedLateness(Duration.ZERO));
>  * }</pre>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)