[GitHub] [flink] akalash commented on a change in pull request #17331: [FLINK-24344][runtime] Calling the CheckpointFailureManager even if the exception happens during the checkpoint initialization

[GitBox <gi...@apache.org>]

akalash commented on a change in pull request #17331:
URL: https://github.com/apache/flink/pull/17331#discussion_r713852975



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -1955,6 +1959,25 @@ private void abortPendingCheckpoint(
         }
     }
 
+    private void handleCheckpointException(
+            PendingCheckpoint pendingCheckpoint,
+            CheckpointProperties checkpointProperties,
+            CheckpointException exception,
+            ExecutionAttemptID executionAttemptID) {
+        if (checkpointProperties.isSavepoint()
+                && (checkpointProperties.isSynchronous() || pendingCheckpoint == null)) {
+            failureManager.handleSynchronousSavepointFailure(exception);

Review comment:
       My idea is if we fail during the initialization phase it means that asynchronous part of the checkpoint/savepoint has not started yet so we can do the same logic as for synchronous savepoint




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org