You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ye...@apache.org on 2009/01/16 12:00:47 UTC
svn commit: r734971 -
/poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java
Author: yegor
Date: Fri Jan 16 03:00:45 2009
New Revision: 734971
URL: http://svn.apache.org/viewvc?rev=734971&view=rev
Log:
fixed unit test failing on jdk-1.6: java code should not rely on the order of HashMap.iterator()
Modified:
poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java
Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java?rev=734971&r1=734970&r2=734971&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/extractor/TestExtractorFactory.java Fri Jan 16 03:00:45 2009
@@ -331,33 +331,38 @@
ext = (POIOLE2TextExtractor)
ExtractorFactory.createExtractor(f);
embeds = ExtractorFactory.getEmbededDocsTextExtractors(ext);
-
+
assertEquals(6, embeds.length);
- assertTrue(embeds[0] instanceof PowerPointExtractor);
- assertTrue(embeds[1] instanceof ExcelExtractor);
- assertTrue(embeds[2] instanceof ExcelExtractor);
- assertTrue(embeds[3] instanceof PowerPointExtractor);
- assertTrue(embeds[4] instanceof WordExtractor);
- assertTrue(embeds[5] instanceof WordExtractor);
- for(int i=0; i<embeds.length; i++) {
+ int numWord = 0, numXls = 0, numPpt = 0;
+ for(int i=0; i<embeds.length; i++) {
assertTrue(embeds[i].getText().length() > 20);
- }
-
- // Word
+
+ if(embeds[i] instanceof PowerPointExtractor) numPpt++;
+ else if(embeds[i] instanceof ExcelExtractor) numXls++;
+ else if(embeds[i] instanceof WordExtractor) numWord++;
+ }
+ assertEquals(2, numPpt);
+ assertEquals(2, numXls);
+ assertEquals(2, numWord);
+
+ // Word
f = new File(poifs_dir, "word_with_embeded.doc");
ext = (POIOLE2TextExtractor)
ExtractorFactory.createExtractor(f);
embeds = ExtractorFactory.getEmbededDocsTextExtractors(ext);
+ numWord = 0; numXls = 0; numPpt = 0;
assertEquals(4, embeds.length);
- assertTrue(embeds[0] instanceof WordExtractor);
- assertTrue(embeds[1] instanceof ExcelExtractor);
- assertTrue(embeds[2] instanceof ExcelExtractor);
- assertTrue(embeds[3] instanceof PowerPointExtractor);
for(int i=0; i<embeds.length; i++) {
assertTrue(embeds[i].getText().length() > 20);
+ if(embeds[i] instanceof PowerPointExtractor) numPpt++;
+ else if(embeds[i] instanceof ExcelExtractor) numXls++;
+ else if(embeds[i] instanceof WordExtractor) numWord++;
}
-
+ assertEquals(1, numPpt);
+ assertEquals(2, numXls);
+ assertEquals(1, numWord);
+
// TODO - PowerPoint
// TODO - Visio
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org