[GitHub] [ofbiz-framework] ieugen commented on a change in pull request #317: Clojure engine for OFBiz

[GitBox <gi...@apache.org>]

ieugen commented on a change in pull request #317:
URL: https://github.com/apache/ofbiz-framework/pull/317#discussion_r679445433



##########
File path: framework/common/servicedef/services.xml
##########
@@ -45,6 +45,10 @@ under the License.
             location="org.apache.ofbiz.common.CommonServices" invoke="echoService">
         <description>Echos back all passed parameters</description>
     </service>
+    <service name="echo-service" engine="clojure" validate="false"

Review comment:
       is this a hard rule? 
   echo-service is closer to clojure semantics. 
   Clojure can have functions called like: "are-we>there-yet?". 
   If it's not a requirement, I would prefer to keep it as is. 
   
   
   Also, IMO OFBiz could use namespaces for services - it will help in grouping them based on functionality and will keep the names shorter:
   
   party/xxxx
   order/xxx
   accounting/xxxx
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org