[GitHub] [beam] lostluck commented on a diff in pull request #24175: Update automation to use Go 1.19

[GitBox <gi...@apache.org>]

lostluck commented on code in PR #24175:
URL: https://github.com/apache/beam/pull/24175#discussion_r1023245251


##########
.github/workflows/go_tests.yml:
##########
@@ -44,7 +44,7 @@ jobs:
           fetch-depth: 2
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.18'
+          go-version: '1.19'

Review Comment:
   No.
   
   For all that BeamGo is doing, it's not that compiler version sensitive (thus far), and we'd have other issues in our dependencies first. Go's very keen on the Go 1 Support policy, and that's not changing.
   
   I'm more concerned that we continue working going forward, rather than backwards, since that gives us better signal, with an action (fix it going forward), and a recommendation for users (use the latest Beam Go with the latest version of Go).
   
   We're also more likely to adopt newer features going forward for more robust examples or type inference changes to generics, etc, so the "oldest supported version" isn't meaningful from a SDK support perspective either. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org