You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/01/31 02:28:32 UTC

[GitHub] [yunikorn-k8shim] wilfred-s commented on pull request #518: [YUNIKORN-1549] Introduce a config to specify what attribute to use as instance type

wilfred-s commented on PR #518:
URL: https://github.com/apache/yunikorn-k8shim/pull/518#issuecomment-1409651916

   -1 on the proposal and implementation
   
   The k8shim should pass all labels that are defined on a node, no filtering, as tags to the core.
   That is what is implemented in YUNIKORN-1389. I do think that the way that jira is implemented is broken to begin with.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org