You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2004/04/28 20:51:49 UTC
RFC: merge fs-abstraction branch onto trunk
I believe the fs-abstraction branch to be ready for merging onto the
trunk. The user-visible changes can be summarized as:
* svnadmin create --fs-type=fsfs creates an FSFS repository.
* A build without Berkeley DB now builds server components.
("svnadmin create" will fail without --fs-type=fsfs, and most of
the tests will be skipped unless you run make fsfscheck.)
If you would like a chance to review the work on the branch before it
goes into the trunk, speak up, and say how much time you'd like to be
given.
If no one speaks up, and I don't discover any reason why I was wrong
about the branch, I'll merge it in tomorrow evening.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by Garrett Rooney <ro...@electricjellyfish.net>.
On Apr 28, 2004, at 7:28 PM, Eric Gillespie wrote:
> Greg Hudson <gh...@MIT.EDU> writes:
>
>> I believe the fs-abstraction branch to be ready for merging
>> onto the trunk.
>
> +1
+1
> As someone who has long been excited by Greg's threats to
> implement this backend, i have been following the work closely
> and reading over the commits as they come in. I think i have a
> pretty good understanding of how it all works and thus can vote
> for its merging with some confidence.
What he said.
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by Eric Gillespie <ep...@pretzelnet.org>.
Greg Hudson <gh...@MIT.EDU> writes:
> I believe the fs-abstraction branch to be ready for merging
> onto the trunk.
+1
As someone who has long been excited by Greg's threats to
implement this backend, i have been following the work closely
and reading over the commits as they come in. I think i have a
pretty good understanding of how it all works and thus can vote
for its merging with some confidence.
--
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by Greg Hudson <gh...@MIT.EDU>.
Branko wrote:
> Has this been built/tested on anything but Unix? I'd rather not
> unscramble the Win32 build on the trunk, if possible.
Well, Chris Foote didn't say so specifically, but the implication is
that it builds on Windows. And it's all pretty basic APR file
manipulation, so I think there shouldn't be much unscrambling to do,
if any.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by Branko Čibej <br...@xbc.nu>.
Greg Hudson wrote:
>I believe the fs-abstraction branch to be ready for merging onto the
>trunk. The user-visible changes can be summarized as:
>
> * svnadmin create --fs-type=fsfs creates an FSFS repository.
> * A build without Berkeley DB now builds server components.
> ("svnadmin create" will fail without --fs-type=fsfs, and most of
> the tests will be skipped unless you run make fsfscheck.)
>
>If you would like a chance to review the work on the branch before it
>goes into the trunk, speak up, and say how much time you'd like to be
>given.
>
>If no one speaks up, and I don't discover any reason why I was wrong
>about the branch, I'll merge it in tomorrow evening.
>
>
Has this been built/tested on anything but Unix? I'd rather not
unscramble the Win32 build on the trunk, if possible.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by kf...@collab.net.
Greg Hudson <gh...@MIT.EDU> writes:
> Probably the easiest way would be to run "make svncheck FS_TYPE=fsfs" or
> whatever.
>
> It's possible that we'd want to cover the full matrix of RA/FS
> combinations for testing a release, in case there are any unfortunate
> interactions, but for the most part you'd just be testing the same RA
> code twice and the same FS code three or four times.
As long as there's a way, and it's documented, that's mainly what I'm
after, thanks.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by Greg Hudson <gh...@MIT.EDU>.
On Thu, 2004-04-29 at 14:11, kfogel@collab.net wrote:
> Re the regression test change: Right now, we have
>
> make check
> make svncheck
> make davcheck
>
> The choice axis is "ra layer", not "repository backend".
> What RA layer does 'make fsfscheck' run over?
ra_local
> How does one choose between different RA layers when testing fsfs?
Probably the easiest way would be to run "make svncheck FS_TYPE=fsfs" or
whatever.
It's possible that we'd want to cover the full matrix of RA/FS
combinations for testing a release, in case there are any unfortunate
interactions, but for the most part you'd just be testing the same RA
code twice and the same FS code three or four times.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: RFC: merge fs-abstraction branch onto trunk
Posted by kf...@collab.net.
Greg Hudson <gh...@MIT.EDU> writes:
> I believe the fs-abstraction branch to be ready for merging onto the
> trunk. The user-visible changes can be summarized as:
>
> * svnadmin create --fs-type=fsfs creates an FSFS repository.
> * A build without Berkeley DB now builds server components.
> ("svnadmin create" will fail without --fs-type=fsfs, and most of
> the tests will be skipped unless you run make fsfscheck.)
>
> If you would like a chance to review the work on the branch before it
> goes into the trunk, speak up, and say how much time you'd like to be
> given.
Re the regression test change: Right now, we have
make check
make svncheck
make davcheck
The choice axis is "ra layer", not "repository backend".
What RA layer does 'make fsfscheck' run over? How does one choose
between different RA layers when testing fsfs?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: merge fs-abstraction branch onto trunk
Posted by Chris Foote <cf...@v21.me.uk>.
Yes, it would then build on windows.
With the following patch some very basic tests pass.
- Create and do a commit to a bdb repo.
- Create an fs repo, but commit fails, with this error:
Transmitting file data .svn: Commit failed (details follow):
svn: Can't remove 'D:/repos/fsfs-test/db/transactions/RxmMpD.txn':
The directory is not empty.
But looking at the directory it is empty.
Hope this helps.
Regards,
Chris
Index: svn_private_config.hw
===================================================================
--- svn_private_config.hw (revision 9568)
+++ svn_private_config.hw (working copy)
@@ -36,6 +36,12 @@
/* Name of system's null device */
#define SVN_NULL_DEVICE_NAME "nul"
+/* Link fs base library into the fs library */
+#define SVN_LIBSVN_FS_LINKS_FS_BASE
+
+/* Link fs fs library into the fs library */
+#define SVN_LIBSVN_FS_LINKS_FS_FS
+
/* Link local repos access library to client */
#define SVN_LIBSVN_CLIENT_LINKS_RA_LOCAL
----- Original Message -----
From: "Greg Hudson" <gh...@MIT.EDU>
To: "Chris Foote" <cf...@v21.me.uk>
Cc: <de...@subversion.tigris.org>
Sent: Thursday, April 29, 2004 1:16 AM
Subject: Re: merge fs-abstraction branch onto trunk
> On Wed, 2004-04-28 at 20:02, Chris Foote wrote:
> > The win32 build needs the following patch.
> > Also need to add svn:eol-style=native to the files in libsvn_fs.
>
> Done.
>
> Does that mean it builds on Windows, or were those just the first
> problems you ran into?
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: merge fs-abstraction branch onto trunk
Posted by Greg Hudson <gh...@MIT.EDU>.
On Wed, 2004-04-28 at 20:02, Chris Foote wrote:
> The win32 build needs the following patch.
> Also need to add svn:eol-style=native to the files in libsvn_fs.
Done.
Does that mean it builds on Windows, or were those just the first
problems you ran into?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: merge fs-abstraction branch onto trunk
Posted by Chris Foote <cf...@v21.me.uk>.
----- Original Message -----
From: "Greg Hudson" <gh...@MIT.EDU>
To: <de...@subversion.tigris.org>
Sent: Wednesday, April 28, 2004 9:51 PM
Subject: RFC: merge fs-abstraction branch onto trunk
> I believe the fs-abstraction branch to be ready for merging onto the
> trunk.
...
> If no one speaks up, and I don't discover any reason why I was wrong
> about the branch, I'll merge it in tomorrow evening.
>
The win32 build needs the following patch.
Also need to add svn:eol-style=native to the files in libsvn_fs.
Regards
Chris
Log:
Build the fsap libraries as static libs on Win32.
* build.conf
(libsvn_fs_base, libsvn_fs_fs): Add msvc-static.
Index: build.conf
===================================================================
--- build.conf (revision 9557)
+++ build.conf (working copy)
@@ -153,6 +153,7 @@
sources = *.c bdb/*.c util/*.c
install = bdb-lib
libs = libsvn_delta libsvn_subr aprutil apriconv bdb apr
+msvc-static = yes
[libsvn_fs_fs]
type = fs-module
@@ -160,6 +161,7 @@
sources = *.c
install = lib
libs = libsvn_delta libsvn_subr aprutil apriconv apr
+msvc-static = yes
# General API for accessing repositories
[libsvn_ra]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org