You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Hitesh Khamesra <hk...@pivotal.io> on 2016/12/01 23:45:18 UTC
Review Request 54272: GEODE-2162 AsyncEventListenerDUnitTest
testParallelAsyncEventQueueWithOneAccessor hang on tearDown
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54272/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
Repository: geode
Description
-------
It seems member is waiting for elder to change. New view should have informed it. I just removed extra boolean flag which can cause not to notify to waiting thread.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 872016b
Diff: https://reviews.apache.org/r/54272/diff/
Testing
-------
Thanks,
Hitesh Khamesra
Re: Review Request 54272: GEODE-2162 AsyncEventListenerDUnitTest
testParallelAsyncEventQueueWithOneAccessor hang on tearDown
Posted by Hitesh Khamesra <hk...@pivotal.io>.
> On Dec. 2, 2016, 12:31 a.m., Bruce Schuchardt wrote:
> > I'd like to talk with you about this change. The whole wait/notify thing seems fragile to me - a Future might be a lot better device to use here.
yeah lets talk tomorrow on this. Thanks.
- Hitesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54272/#review157680
-----------------------------------------------------------
On Dec. 1, 2016, 11:45 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54272/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 11:45 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> It seems member is waiting for elder to change. New view should have informed it. I just removed extra boolean flag which can cause not to notify to waiting thread.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 872016b
>
> Diff: https://reviews.apache.org/r/54272/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>
Re: Review Request 54272: GEODE-2162 AsyncEventListenerDUnitTest
testParallelAsyncEventQueueWithOneAccessor hang on tearDown
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54272/#review157680
-----------------------------------------------------------
I'd like to talk with you about this change. The whole wait/notify thing seems fragile to me - a Future might be a lot better device to use here.
- Bruce Schuchardt
On Dec. 1, 2016, 11:45 p.m., Hitesh Khamesra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54272/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 11:45 p.m.)
>
>
> Review request for geode, Bruce Schuchardt and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> It seems member is waiting for elder to change. New view should have informed it. I just removed extra boolean flag which can cause not to notify to waiting thread.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/DistributionManager.java 872016b
>
> Diff: https://reviews.apache.org/r/54272/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hitesh Khamesra
>
>