You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/02 13:30:10 UTC
[GitHub] [arrow] vvellanki commented on a change in pull request #11471: ARROW-14389: [C++][Gandiva] WIP Fix performance bug with LIKE expressions with reserved characters
vvellanki commented on a change in pull request #11471:
URL: https://github.com/apache/arrow/pull/11471#discussion_r741050024
##########
File path: cpp/src/gandiva/like_holder.cc
##########
@@ -25,7 +25,7 @@ namespace gandiva {
RE2 LikeHolder::starts_with_regex_(R"((\w|\s)*\.\*)");
RE2 LikeHolder::ends_with_regex_(R"(\.\*(\w|\s)*)");
-RE2 LikeHolder::is_substr_regex_(R"(\.\*(\w|\s)*\.\*)");
+RE2 LikeHolder::is_substr_regex_(R"(\.\*(\w|\s|\W)*\.\*)");
Review comment:
I am not sure if you can include all non-word characters.
From https://github.com/google/re2/wiki/Syntax:
\W | not word characters (≡ [^0-9A-Za-z_])
-- | --
Does RE2 support matching with non-ascii character sets?
##########
File path: cpp/src/gandiva/like_holder.cc
##########
@@ -25,7 +25,7 @@ namespace gandiva {
RE2 LikeHolder::starts_with_regex_(R"((\w|\s)*\.\*)");
Review comment:
You can include characters like - to this list. Same with ends_with optimisation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org