You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "huwh (via GitHub)" <gi...@apache.org> on 2023/03/23 05:09:29 UTC

[GitHub] [flink] huwh opened a new pull request, #22243: [FLINK-31541] encode request params to support special characters metrics name.

huwh opened a new pull request, #22243:
URL: https://github.com/apache/flink/pull/22243

   ## What is the purpose of the change
   User could set operator name with some special characters, such as '%' and '['. This cause request failed when try to get metrics of this operator in WEB UI. 
   
   ## Brief change log
     - *move the request parameters from url to option:params to let http client encode the special characters *
   
   ## Verifying this change
     - *Run web ui with special operator name, metrics could be retrieved successfully.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
    
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa commented on pull request #22243: [FLINK-31541][UI] encode request params to support special characters metrics name.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on PR #22243:
URL: https://github.com/apache/flink/pull/22243#issuecomment-1480963921

   @yangjunhan Would you mind taking a look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22243: [FLINK-31541][UI] encode request params to support special characters metrics name.

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22243:
URL: https://github.com/apache/flink/pull/22243#issuecomment-1480615120

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "60258059b8fdfbaca92635789f685a32b745c990",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "60258059b8fdfbaca92635789f685a32b745c990",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 60258059b8fdfbaca92635789f685a32b745c990 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] reswqa closed pull request #22243: [FLINK-31541][UI] encode request params to support special characters metrics name.

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa closed pull request #22243: [FLINK-31541][UI] encode request params to support special characters metrics name.
URL: https://github.com/apache/flink/pull/22243


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org