You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by oknet <gi...@git.apache.org> on 2016/06/30 12:34:09 UTC
[GitHub] trafficserver pull request #771: Proposal: InactivityCop Optimize
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/771
Proposal: InactivityCop Optimize
Optimize InactivityCop on a heavy load and high level concurrent connection system.
It is set default inactivity timeout before put vc into open_list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-4612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #771
----
commit 2ba5b002ee14d75142f027dc602ab05ac8ce35db
Author: Oknet Xu <xu...@skyguard.com.cn>
Date: 2016-06-30T12:13:46Z
Proposal: InactivityCop Optimize
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71293917
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
I don't see how this would be used.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
@bryancall to review the codes of ClusterHandlerBase.cc
```
979 thread = eventProcessor.eventthread[ET_CLUSTER][id % num_of_cluster_threads];
980 if (net_vc->thread == thread) {
981 cluster_connect_state = CLCON_CONN_BIND_OK;
982 break;
983 } else {
984 cluster_connect_state = ClusterHandler::CLCON_CONN_BIND_CLEAR;
985 }
```
From my understanding of the code, the codes from L1007 to L1033 means:
1. the net_vc bind to unmatched thread
2. It should unbind(L1012-1022) and then rebind(L1024-L1027) to another thread
I think the unbind include remove vc from cop_list here.
because the InactivityCop only push the vc->thread == this_ethread() into cop_list, but the vc->thread set to NULL in L1014.
```
// Copy the list and use pop() to catch any closes caused by callbacks.
forl_LL(UnixNetVConnection, vc, nh.open_list)
{
if (vc->thread == this_ethread()) {
nh.cop_list.push(vc);
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
@oknet This fails on the clang-format, can you please fix and push an update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/771
@oknet I don't think it is necessary to remove it from the cop_list, since it is currently not being removed from the list and it is checking the inactivity timeouts. I would leave it as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71296490
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
Step 1. put all vc in open_list into cop_list.
Step 2. remove vc from cop_list if it has READ/WRITE event. (running 100 times)
Step 3. call check_inactivity() to processing cop_list.
Step 4. go to step 1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/632/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/856/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/855/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/752/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
rebased on master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71292554
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -1304,9 +1305,10 @@ UnixNetVConnection::connectUp(EThread *t, int fd)
SET_HANDLER(&UnixNetVConnection::mainEvent);
nh = get_NetHandler(t);
+ set_inactivity_timeout(0);
nh->open_list.enqueue(this);
- ink_assert(!inactivity_timeout_in);
+ // ink_assert(!inactivity_timeout_in);
--- End diff --
This can be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
GitHub user oknet reopened a pull request:
https://github.com/apache/trafficserver/pull/771
TS-4612: Proposal: InactivityCop Optimize
Optimize InactivityCop on a heavy load and high level concurrent connection system.
It is set default inactivity timeout before put vc into open_list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-4612
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/771.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #771
----
commit b3441cfcc7dbabb22e01d437b5940f4b50f07691
Author: Oknet Xu <xu...@skyguard.com.cn>
Date: 2016-06-30T12:13:46Z
Proposal: InactivityCop Optimize
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/372/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/475/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
Where are we with this? Ready to land?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/771
@zwoop Yes, this should be merged after the clang-format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/771
@oknet would you mind revising the commit subject and descripton?
```
TS-4612: Optimize InactivityCop.
Longer description here. Capture the important points from this PR and from the Jira explanation.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
update iocore/cluster/ClusterHandlerBase.cc @bryancall @zwoop
but I have no environment to perform cluster system test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
clang-format is done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/528/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
@bryancall I'm found open_list also used in Cluster.
file: iocore/cluster/ClusterHandlerBase.cc
```
1007 case ClusterHandler::CLCON_CONN_BIND_CLEAR: {
1008 UnixNetVConnection *vc = (UnixNetVConnection *)net_vc;
1009 MUTEX_TRY_LOCK(lock, vc->nh->mutex, e->ethread);
1010 MUTEX_TRY_LOCK(lock1, vc->mutex, e->ethread);
1011 if (lock.is_locked() && lock1.is_locked()) {
1012 vc->ep.stop();
1013 vc->nh->open_list.remove(vc);
1014 vc->thread = NULL;
1015 if (vc->nh->read_ready_list.in(vc))
1016 vc->nh->read_ready_list.remove(vc);
1017 if (vc->nh->write_ready_list.in(vc))
1018 vc->nh->write_ready_list.remove(vc);
1019 if (vc->read.in_enabled_list)
1020 vc->nh->read_enable_list.remove(vc);
1021 if (vc->write.in_enabled_list)
1022 vc->nh->write_enable_list.remove(vc);
1023
1024 // CLCON_CONN_BIND handle in bind vc->thread (bind thread nh)
1025 cluster_connect_state = ClusterHandler::CLCON_CONN_BIND;
1026 thread->schedule_in(this, CLUSTER_PERIOD);
1027 return EVENT_DONE;
1028 } else {
1029 // CLCON_CONN_BIND_CLEAR handle in origin vc->thread (origin thread nh)
1030 vc->thread->schedule_in(this, CLUSTER_PERIOD);
1031 return EVENT_DONE;
1032 }
1033 }
```
Is there have InactivityCop for Cluster? I am not familiar with the cluster.
I'm should add "vc->nh->cop_list.remove(vc);" after Line 1013 if yes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/771
@jpeach @bryancall add comments and details in commit message
```
Load the NetVCs from open_list to cop_list before next InactivityCop
runs. NetHandler will remove NetVC from cop_list if it is triggered. As
the NetHandler runs, the number of NetVCs in the cop_list is decreasing.
Lots of NetVCs will be removed from cop_list because the NetHandler runs
100 times maximum between InactivityCop runs. Therefore we don't have to
check all the NetVCs as much as open_list.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet closed the pull request at:
https://github.com/apache/trafficserver/pull/771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71490427
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
NetHandler runs per 10ms\uff0cInactivityCop runs per 1s.
NetHandler runs 100 times between InactivityCop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/771
@bryancall Should we merge this? [approve ci].
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet closed the pull request at:
https://github.com/apache/trafficserver/pull/771
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/367/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71490006
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
What do you mean by "running 100 times"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by oknet <gi...@git.apache.org>.
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71972136
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
No bug and no issue here, the PR is only used to optimize InactivityCop.
Currently, I have no exactly numbers about this change, but the max concurrent connections test has been in the plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #771: TS-4612: Proposal: InactivityCop Optimize
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/771#discussion_r71512654
--- Diff: iocore/net/UnixNet.cc ---
@@ -465,6 +433,9 @@ NetHandler::mainNetEvent(int event, Event *e)
epd = (EventIO *)get_ev_data(pd, x);
if (epd->type == EVENTIO_READWRITE_VC) {
vc = epd->data.vc;
+ if (cop_list.in(vc)) {
+ cop_list.remove(vc);
+ }
--- End diff --
Thank you for the clarification. I am good with the changes. Do you have any numbers around this change and the benefits?
There will be changes to the scheduler and the frequency maybe more than that in the future. I don't see that as an issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/751/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/854/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/750/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #771: TS-4612: Proposal: InactivityCop Optimize
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/771
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/470/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---