[jira] Commented: (HIVE-182) Add database name parameter to getTable and dropTable in Hive.java

["Ashish Thusoo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12657860#action_12657860 ] 

Ashish Thusoo commented on HIVE-182:
------------------------------------

Looks good to me.

While we are at this, maybe we should just get rid of the old calls and pass "default" from ql to the metastore calls. We could encode the db name as a string in the BaseSemanticAnalyzer for now and just make ql use this api instead of the new one. It is just a few places where these calls are made and would also help us to easily address dbname to the query language in the future.

Thoughts?


> Add database name parameter to getTable and dropTable in Hive.java
> ------------------------------------------------------------------
>
>                 Key: HIVE-182
>                 URL: https://issues.apache.org/jira/browse/HIVE-182
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>             Fix For: 0.2.0
>
>         Attachments: HIVE-182.patch
>
>
> Currently the methods in the Hive class in the ql module look like this:
> public void dropTable(String tableName) throws HiveException
> public Table getTable(final String tableName) throws HiveException
> I'd like to be able to specify the database for the tests in HIVE-142 so I propose adding:
> public void dropTable(String dbName, String tableName) throws HiveException
> public Table getTable(final String dbName, final String tableName) throws HiveException

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.