You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/01/24 15:59:50 UTC
Review Request 55886: Remove thrown exceptions while validating
Kerberos Authentication configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55886/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
Bugs: AMBARI-19695
https://issues.apache.org/jira/browse/AMBARI-19695
Repository: ambari
Description
-------
When starting Ambari where Kerberos authentication is enabled (authentication.kerberos.enabled=true), Ambari validates the relevant configuration properties. If a sever issue is found, an exception is thrown. This causes issues in installations where Ambari is expected to be able to perform Kerberos authentication but all of the data is available for since this is it expected to be provided later. For example, the SPNEGO keytab file will be created when Kerberos is enabled sometime after Ambari starts up.
To prevent Ambari from shutting down when all the required data is not available, thrown exceptions should be removed from org.apache.ambari.server.configuration.Configuration#createKerberosAuthenticationProperties.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df1b627
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java d7cb8a3
Diff: https://reviews.apache.org/r/55886/diff/
Testing
-------
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 55886: Remove thrown exceptions while validating
Kerberos Authentication configuration
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55886/#review162957
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 24, 2017, 5:59 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55886/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 5:59 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
>
>
> Bugs: AMBARI-19695
> https://issues.apache.org/jira/browse/AMBARI-19695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When starting Ambari where Kerberos authentication is enabled (authentication.kerberos.enabled=true), Ambari validates the relevant configuration properties. If a sever issue is found, an exception is thrown. This causes issues in installations where Ambari is expected to be able to perform Kerberos authentication but all of the data is available for since this is it expected to be provided later. For example, the SPNEGO keytab file will be created when Kerberos is enabled sometime after Ambari starts up.
> To prevent Ambari from shutting down when all the required data is not available, thrown exceptions should be removed from org.apache.ambari.server.configuration.Configuration#createKerberosAuthenticationProperties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df1b627
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java d7cb8a3
>
> Diff: https://reviews.apache.org/r/55886/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 55886: Remove thrown exceptions while validating
Kerberos Authentication configuration
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55886/#review162829
-----------------------------------------------------------
- Robert Levas
On Jan. 24, 2017, 10:59 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55886/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 10:59 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
>
>
> Bugs: AMBARI-19695
> https://issues.apache.org/jira/browse/AMBARI-19695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When starting Ambari where Kerberos authentication is enabled (authentication.kerberos.enabled=true), Ambari validates the relevant configuration properties. If a sever issue is found, an exception is thrown. This causes issues in installations where Ambari is expected to be able to perform Kerberos authentication but all of the data is available for since this is it expected to be provided later. For example, the SPNEGO keytab file will be created when Kerberos is enabled sometime after Ambari starts up.
> To prevent Ambari from shutting down when all the required data is not available, thrown exceptions should be removed from org.apache.ambari.server.configuration.Configuration#createKerberosAuthenticationProperties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df1b627
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java d7cb8a3
>
> Diff: https://reviews.apache.org/r/55886/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 55886: Remove thrown exceptions while validating
Kerberos Authentication configuration
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55886/#review162828
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Jan. 24, 2017, 10:59 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55886/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 10:59 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Robert Levas.
>
>
> Bugs: AMBARI-19695
> https://issues.apache.org/jira/browse/AMBARI-19695
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When starting Ambari where Kerberos authentication is enabled (authentication.kerberos.enabled=true), Ambari validates the relevant configuration properties. If a sever issue is found, an exception is thrown. This causes issues in installations where Ambari is expected to be able to perform Kerberos authentication but all of the data is available for since this is it expected to be provided later. For example, the SPNEGO keytab file will be created when Kerberos is enabled sometime after Ambari starts up.
> To prevent Ambari from shutting down when all the required data is not available, thrown exceptions should be removed from org.apache.ambari.server.configuration.Configuration#createKerberosAuthenticationProperties.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java df1b627
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java d7cb8a3
>
> Diff: https://reviews.apache.org/r/55886/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>