[jira] [Commented] (PDFBOX-1646) [PATCH] Add method for retrieving CFF bounding box from CFFFont class with slight refactoring and optimization.

["John Hewson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PDFBOX-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872407#comment-13872407 ] 

John Hewson commented on PDFBOX-1646:
-------------------------------------

The FOP project no longer requires the bounding box patch [1], which makes this issue redundant, can we close it?

[1] https://issues.apache.org/jira/browse/PDFBOX-1645?focusedCommentId=13871851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13871851

> [PATCH] Add method for retrieving CFF bounding box from CFFFont class with slight refactoring and optimization.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: PDFBOX-1646
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-1646
>             Project: PDFBox
>          Issue Type: Improvement
>          Components: FontBox
>    Affects Versions: 1.8.2
>            Reporter: Robert Meyer
>            Assignee: Andreas Lehmkühler
>             Fix For: 2.0.0
>
>         Attachments: patch-optimize.diff, patch.diff
>
>
> I have added a method to the CFFFont class to retrieve the bounding box for a character determined by an SID as well as retrieving a name. I have also slightly modified the existing code so that each sid mapping can be retrieved now using the SID as the key from a map. From looking around there are several examples of where iterative loops are used using the original mapping array:
> CFFFontROS.java:165
> CFFParser.java:876
> I haven't changed those locations yet, but they can be made in a separate patch which should boost performance.
> There was a small bit of refactoring done as well just because I now retrieve a renderer from two locations. These patches are part of adding OTF CFF support to Apache FOP.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)