You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/07/23 17:03:54 UTC

[GitHub] [beam] pabloem commented on a change in pull request #12352: [BEAM-10549] Improve runtime type checking performance for the Python SDK

pabloem commented on a change in pull request #12352:
URL: https://github.com/apache/beam/pull/12352#discussion_r459597380



##########
File path: sdks/python/apache_beam/runners/worker/opcounters.py
##########
@@ -202,6 +205,17 @@ def __init__(
     self._sample_counter = 0
     self._next_sample = 0
 
+    if consumers and len(consumers):

Review comment:
       You can just do `if consumers` here.
   
   As discussed, there may be more than one consumer, so worth thinking about what to do in that case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org