cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/core Context.java Request.java

[ru...@locus.apache.org]

rubys       00/01/03 18:53:06

  Modified:    src/share/org/apache/jasper/compiler JspReader.java
               src/share/org/apache/tomcat/core Context.java Request.java
  Log:
  Eliminate Jikes warnings / be more defensive
  
  Revision  Changes    Path
  1.8       +1 -1      jakarta-tomcat/src/share/org/apache/jasper/compiler/JspReader.java
  
  Index: JspReader.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/jasper/compiler/JspReader.java,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- JspReader.java	1999/12/29 21:27:29	1.7
  +++ JspReader.java	2000/01/04 02:53:05	1.8
  @@ -161,7 +161,7 @@
                   
                   try {
                       reader = new InputStreamReader(in);
  -                } catch (Exception ex) {
  +                } catch (Throwable ex) {
                       throw new FileNotFoundException(fileName + ": "+ ex.getMessage());
                   }
               }
  
  
  
  1.11      +1 -1      jakarta-tomcat/src/share/org/apache/tomcat/core/Context.java
  
  Index: Context.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Context.java,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- Context.java	1999/11/06 00:19:50	1.10
  +++ Context.java	2000/01/04 02:53:06	1.11
  @@ -190,7 +190,7 @@
   
           try {
   	    f = new File(workDir);
  -	} catch (Exception e) {
  +	} catch (Throwable e) {
   	}
   
   	setWorkDir(f, isWorkDirPersistent);
  
  
  
  1.10      +5 -5      jakarta-tomcat/src/share/org/apache/tomcat/core/Request.java
  
  Index: Request.java
  ===================================================================
  RCS file: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Request.java,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- Request.java	1999/12/29 04:54:15	1.9
  +++ Request.java	2000/01/04 02:53:06	1.10
  @@ -1,7 +1,7 @@
   /*
  - * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Request.java,v 1.9 1999/12/29 04:54:15 bergsten Exp $
  - * $Revision: 1.9 $
  - * $Date: 1999/12/29 04:54:15 $
  + * $Header: /home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/core/Request.java,v 1.10 2000/01/04 02:53:06 rubys Exp $
  + * $Revision: 1.10 $
  + * $Date: 2000/01/04 02:53:06 $
    *
    * ====================================================================
    *
  @@ -474,7 +474,7 @@
   
           try {
               this.parameters = HttpUtils.parseQueryString(queryString);
  -        } catch (Exception e) {
  +        } catch (Throwable e) {
               this.parameters.clear();
           }
       }
  @@ -508,7 +508,7 @@
           Hashtable newParameters = null;
           try {
               newParameters = HttpUtils.parseQueryString(queryString);
  -        } catch (Exception e) {
  +        } catch (Throwable e) {
               return;
           }
   
  
  
  

Bug?

[Paolo Barolat <pm...@drexel.edu>]

Hello.  I have been doing some work with Tomcat and I think I might have found an issue.  However, I'm new to this so I don't
want to jump the gun.

The specifications located at

http://developer.java.sun.com/developer/earlyAccess/j2sdkee/doc-beta-2/api/javax/servlet/http/HttpServletRequest.html#getCookies()

state:

public Cookie[] getCookies()

       Returns an array containing all of the Cookie objects the client sent with this request. This method returns null if no
cookies were sent.
       Returns:
              an array of all the Cookies included with this request, or null if the request has no cookies

However, when I don't have any cookies on my browser from my site, the array is not null.  Rather, when I have it print out on
the responding page the length of the Cookie array, it says that the length of the array is zero.

Is this a bug?  Am I look at the wrong documentations?  Do I have an olde version of Tomcat?

Thanks,

Paolo