You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/26 10:14:02 UTC

[GitHub] [fineract] Grandolf49 opened a new pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Grandolf49 opened a new pull request #1285:
URL: https://github.com/apache/fineract/pull/1285


   ## Description
   This is a backport PR for `1.4.0`. It addresses FINERACT-1101. Read #1271 for more details.
    
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [x] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [x] Integration tests have been created/updated for verifying the changes made.
   
   - [x] All Integrations tests are passing with the new commits.
   
   - [x] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vidakovic commented on pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #1285:
URL: https://github.com/apache/fineract/pull/1285#issuecomment-681150542


   @Grandolf49 please have look at #1292 and comment if that works for you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] Grandolf49 commented on pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on pull request #1285:
URL: https://github.com/apache/fineract/pull/1285#issuecomment-680799104


   > Did you also raise a PR for develop branch? Else if we merge this on branch 1.4.0 only, then develop branch and subsequently the next release will lack this PR. Maybe we should just merge everything on develop? and let @vidakovic decide what to cherry pick. cc @vorburger
   
   Yes this is merged in develop already. Check this PR #1271


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] Grandolf49 commented on pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Posted by GitBox <gi...@apache.org>.
Grandolf49 commented on pull request #1285:
URL: https://github.com/apache/fineract/pull/1285#issuecomment-682148814


   @vidakovic #1292 LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vidakovic merged pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #1285:
URL: https://github.com/apache/fineract/pull/1285


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum commented on pull request #1285: FINERACT-1101 [Backport PR] Added Mustache templates to Swagger Codegen

Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1285:
URL: https://github.com/apache/fineract/pull/1285#issuecomment-680798100


   Did you also raise a PR for develop branch? Else if we merge this on branch 1.4.0 only, then develop branch and subsequently the next release will lack this PR. Maybe we should just merge everything on develop? and let @vidakovic decide what to cherry pick. cc @vorburger 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org