You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/11 04:52:14 UTC

[GitHub] [airflow] edwinkong opened a new issue #15773: [SambaHook] Can not extract domain from the username

edwinkong opened a new issue #15773:
URL: https://github.com/apache/airflow/issues/15773


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   These questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**:
   2.0.1
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   
   **Environment**: docker-compose + custom built docker image
   
   **What happened**:
   
   The `airflow.providers.samba.hooks.samba.SambaHook` does not accept the `domain` argument and is automatically defaults to the server ip address by upstream `pysmbclient`.
   If the DOMAIN/USERNAME format was supplied, it would fail with `NT_STATUS_BAD_NETWORK_NAME` error. If only the USERNAME was supplied, then the login would fail with `NT_STATUS_LOGON_FAILURE` error.
   
   **What you expected to happen**:
   The domain should be extracted from the username if the user supplied the `SambaHook.conn.login` in the DOMAIN/USERNAME format.
   
   **How to reproduce it**:
   Just connect to a samba drive with domain authentication with `SambaHook`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] edwinkong commented on issue #15773: [SambaHook] Can not extract domain from the username

Posted by GitBox <gi...@apache.org>.
edwinkong commented on issue #15773:
URL: https://github.com/apache/airflow/issues/15773#issuecomment-837911288


   I am sorry for not checking the upstream before opening an issue here. The upstream project `pysmbclient` was last updated at 9 years ago so the project is very likely to be obsolete. The `NT_STATUS_BAD_NETWORK_NAME` error was raised due to the faulty `subprocess` call
   ```
   smbclient [SHARE] -I [IP] -A [AUTH_FILE] -c ls "[PATH]"
   ```
   the double quote doesn't include the `ls` so it fails.
   
   I would create my samba hook myself. Moreover, the `SambaHook` can not even list the directory, so probably some deprecation warning should be displayed when installing the package.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #15773: [SambaHook] Can not extract domain from the username

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15773:
URL: https://github.com/apache/airflow/issues/15773#issuecomment-838070109


   We have open task to move to a maintained library https://github.com/apache/airflow/issues/14054 handled by @marcosmarxm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15773: [SambaHook] Can not extract domain from the username

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #15773:
URL: https://github.com/apache/airflow/issues/15773#issuecomment-837807022


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #15773: [SambaHook] Can not extract domain from the username

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #15773:
URL: https://github.com/apache/airflow/issues/15773


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org