[GitHub] [shardingsphere] lanchengx opened a new pull request #15848: Support ALTER INSTANCE syntax.

[GitBox <gi...@apache.org>]

lanchengx opened a new pull request #15848:
URL: https://github.com/apache/shardingsphere/pull/15848


   For #15405.
   
   Changes proposed in this pull request:
   - Support `ALTER INSTANCE` syntax.
   - Add test of `ALTER INSTANCE` syntax.
   - SHOW INSTANCE LIST added `xa_recovery_id` field.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #15848: Support ALTER INSTANCE syntax.

[GitBox <gi...@apache.org>]

RaigorJiang commented on a change in pull request #15848:
URL: https://github.com/apache/shardingsphere/pull/15848#discussion_r820477448



##########
File path: shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/common/updatable/AlterInstanceHandler.java
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.proxy.backend.text.distsql.ral.common.updatable;
+
+import org.apache.shardingsphere.distsql.parser.statement.ral.common.updatable.AlterInstanceStatement;
+import org.apache.shardingsphere.infra.distsql.exception.DistSQLException;
+import org.apache.shardingsphere.infra.instance.ComputeNodeInstance;
+import org.apache.shardingsphere.mode.manager.ContextManager;
+import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService;
+import org.apache.shardingsphere.proxy.backend.text.distsql.ral.UpdatableRALBackendHandler;
+
+import java.util.Collection;
+import java.util.Optional;
+import java.util.stream.Collectors;
+
+/**
+ * Alter instance handler.
+ */
+public final class AlterInstanceHandler extends UpdatableRALBackendHandler<AlterInstanceStatement, AlterInstanceHandler> {
+    
+    private static final String XA_RECOVERY_ID = "xa_recovery_id";
+    
+    @Override
+    protected void update(final ContextManager contextManager, final AlterInstanceStatement sqlStatement) throws DistSQLException {
+        if (XA_RECOVERY_ID.equalsIgnoreCase(sqlStatement.getKey())) {
+            setXaRecoveryId(contextManager, sqlStatement);
+        } else {
+            throw new UnsupportedOperationException(String.format("%s is not supported", sqlStatement.getKey()));
+        }
+    }
+    
+    private void setXaRecoveryId(final ContextManager contextManager, final AlterInstanceStatement sqlStatement) {
+        Optional<MetaDataPersistService> persistService = contextManager.getMetaDataContexts().getMetaDataPersistService();
+        if (!persistService.isPresent()) {
+            throw new UnsupportedOperationException(String.format("No persistence configuration found, unable to set '%s'", sqlStatement.getKey()));
+        }
+        Collection<ComputeNodeInstance> instances = persistService.get().getComputeNodePersistService().loadAllComputeNodeInstances();
+        checkDuplicated(instances, sqlStatement);
+        persistService.get().getComputeNodePersistService().persistInstanceXaRecoveryId(sqlStatement.getInstanceId(), sqlStatement.getValue());
+        

Review comment:
       unnecessary blank line here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang merged pull request #15848: Support ALTER INSTANCE syntax.

[GitBox <gi...@apache.org>]

RaigorJiang merged pull request #15848:
URL: https://github.com/apache/shardingsphere/pull/15848


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org