You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Carl Steinbach <ca...@cloudera.com> on 2011/04/06 03:01:26 UTC
Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
-----------------------------------------------------------
Review request for hive.
Summary
-------
https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090
Diffs
-----
trunk/metastore/if/hive_metastore.thrift 1088810
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1088810
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1088810
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1088810
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1088810
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1088810
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1088810
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1088810
trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1088810
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1088810
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1088810
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1088810
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1088810
trunk/ql/src/test/queries/clientpositive/database.q 1088810
trunk/ql/src/test/results/clientpositive/database.q.out 1088810
Diff: https://reviews.apache.org/r/551/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/#review462
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
<https://reviews.apache.org/r/551/#comment886>
Doesn't look like this list is referenced anywhere. Please remove.
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/551/#comment887>
The message should be "restrict or cascade clause", not "if force clause". You may also want to consider splitting this into two different rules so that we can output either "restrict clause" or "cascade clause".
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java
<https://reviews.apache.org/r/551/#comment888>
Please replace instances of "force" with "cascade" in this file and everywhere else so that the code is aligned with the HQL grammar.
trunk/ql/src/test/queries/clientpositive/database.q
<https://reviews.apache.org/r/551/#comment889>
Please add a brief comment for each block explaining what you are testing (see earlier examples in this same test).
trunk/ql/src/test/queries/clientpositive/database.q
<https://reviews.apache.org/r/551/#comment890>
Please add a negative test case that attempts to drop a non-empty DB with the RESTRICT clause set. You can probably copy the HQL code in database_drop_not_empty.q
- Carl
On 2011-04-14 00:17:09, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/551/
> -----------------------------------------------------------
>
> (Updated 2011-04-14 00:17:09)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch
>
>
> This addresses bug HIVE-2090.
> https://issues.apache.org/jira/browse/HIVE-2090
>
>
> Diffs
> -----
>
> trunk/metastore/if/hive_metastore.thrift 1091617
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617
> trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617
> trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617
> trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617
> trunk/ql/src/test/queries/clientpositive/database.q 1091617
> trunk/ql/src/test/results/clientpositive/database.q.out 1091617
>
> Diff: https://reviews.apache.org/r/551/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>
Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
-----------------------------------------------------------
(Updated 2011-04-18 19:30:43.636903)
Review request for hive.
Summary (updated)
-------
https://issues.apache.org/jira/secure/attachment/12476401/HIVE-2090.6.patch
This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090
Diffs (updated)
-----
trunk/metastore/if/hive_metastore.thrift 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617
trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617
trunk/ql/src/test/queries/clientnegative/database_drop_not_empty_restrict.q PRE-CREATION
trunk/ql/src/test/queries/clientpositive/database.q 1091617
trunk/ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out PRE-CREATION
trunk/ql/src/test/results/clientpositive/database.q.out 1091617
Diff: https://reviews.apache.org/r/551/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
-----------------------------------------------------------
(Updated 2011-04-14 00:17:09.433334)
Review request for hive.
Changes
-------
Updating diff with https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch
Summary (updated)
-------
https://issues.apache.org/jira/secure/attachment/12476199/HIVE-2090.5.patch
This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090
Diffs (updated)
-----
trunk/metastore/if/hive_metastore.thrift 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617
trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617
trunk/ql/src/test/queries/clientpositive/database.q 1091617
trunk/ql/src/test/results/clientpositive/database.q.out 1091617
Diff: https://reviews.apache.org/r/551/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
-----------------------------------------------------------
(Updated 2011-04-13 01:04:53.612739)
Review request for hive.
Changes
-------
Updating diff with https://issues.apache.org/jira/secure/attachment/12476195/HIVE-2090.4.patch
Summary
-------
https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090
Diffs (updated)
-----
trunk/metastore/if/hive_metastore.thrift 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1091617
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1091617
trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1091617
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1091617
trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1091617
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1091617
trunk/ql/src/test/queries/clientpositive/database.q 1091617
trunk/ql/src/test/results/clientpositive/database.q.out 1091617
Diff: https://reviews.apache.org/r/551/diff
Testing
-------
Thanks,
Carl
Re: Review Request: HIVE-2090: Add "DROP DATABASE ... FORCE"
Posted by Carl Steinbach <ca...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/#review393
-----------------------------------------------------------
trunk/metastore/if/hive_metastore.thrift
<https://reviews.apache.org/r/551/#comment743>
Does changing the Thrift IDL like this break backwards compatibility with older clients?
trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/551/#comment744>
Missing "@param force..."
- Carl
On 2011-04-06 01:01:26, Carl Steinbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/551/
> -----------------------------------------------------------
>
> (Updated 2011-04-06 01:01:26)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> https://issues.apache.org/jira/secure/attachment/12475548/HIVE-2090.3.patch
>
>
> This addresses bug HIVE-2090.
> https://issues.apache.org/jira/browse/HIVE-2090
>
>
> Diffs
> -----
>
> trunk/metastore/if/hive_metastore.thrift 1088810
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1088810
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1088810
> trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 1088810
> trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java 1088810
> trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 1088810
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 1088810
> trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 1088810
> trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1088810
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 1088810
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java 1088810
> trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1088810
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 1088810
> trunk/ql/src/test/queries/clientpositive/database.q 1088810
> trunk/ql/src/test/results/clientpositive/database.q.out 1088810
>
> Diff: https://reviews.apache.org/r/551/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Carl
>
>