You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chris Suich <ch...@netapp.com> on 2013/08/02 15:36:41 UTC
Re: Review Request 13127: UI Plugin Internationalization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13127/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 1:36 p.m.)
Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
Repository: cloudstack-git
Description
-------
This allows UI Plugins to contribute their own internationalized strings to the global js dictionary. Each plugin would define a dictionary.js and several dictionary_<locale>.js files. As each plugin is loaded, the appropriate plugin dictionary is loaded into the global js dictionary (with the global dictionary taking precedence in the event of a conflict).
Diffs
-----
ui/scripts/plugins.js 96ed229
Diff: https://reviews.apache.org/r/13127/diff/
Testing
-------
Thanks,
Chris Suich
Re: Review Request 13127: UI Plugin Internationalization
Posted by Brian Federle <br...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13127/#review25094
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Federle
On Aug. 2, 2013, 1:36 p.m., Chris Suich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13127/
> -----------------------------------------------------------
>
> (Updated Aug. 2, 2013, 1:36 p.m.)
>
>
> Review request for cloudstack, Brian Federle, Jessica Wang, and Pranav Saxena.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> This allows UI Plugins to contribute their own internationalized strings to the global js dictionary. Each plugin would define a dictionary.js and several dictionary_<locale>.js files. As each plugin is loaded, the appropriate plugin dictionary is loaded into the global js dictionary (with the global dictionary taking precedence in the event of a conflict).
>
>
> Diffs
> -----
>
> ui/scripts/plugins.js 96ed229
>
> Diff: https://reviews.apache.org/r/13127/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Suich
>
>