[GitHub] [iceberg] chenjunjiedada commented on pull request #5760: Core: Add minimum data sequence number to ManifestEntry

["chenjunjiedada (via GitHub)" <gi...@apache.org>]

chenjunjiedada commented on PR #5760:
URL: https://github.com/apache/iceberg/pull/5760#issuecomment-1539259409

   > Flink upsert produces position files to dedup records within the same batch and those position deletes prevent from compaction, right? 
   
   Right.
   
   > The issue is not related to concurrency, every rewrite data files would fail afterwards?
   
   Correct, not related to concurrency. 
   
   > Can we solve this by adapting validateNoNewDeletesForDataFiles in RewriteFiles to not conflict when we detect a conflicting position delete file sequence number (different from data sequence number) is the same as the rewritten data file sequence number? 
   
   It should work. What about position deletes that have been rewritten? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org