You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/21 03:20:14 UTC
[GitHub] [spark] uncleGen commented on a change in pull request #26153:
[SPARK-29500][SQL][SS] Support partition column when writing to Kafka
uncleGen commented on a change in pull request #26153: [SPARK-29500][SQL][SS] Support partition column when writing to Kafka
URL: https://github.com/apache/spark/pull/26153#discussion_r336825998
##########
File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala
##########
@@ -515,3 +619,15 @@ class KafkaSinkBatchSuiteV2 extends KafkaSinkBatchSuiteBase {
}
}
}
+
+class TestKafkaPartitioner extends DefaultPartitioner {
+ override def partition(
+ topic: String,
+ key: Any,
+ keyBytes: Array[Byte],
+ value: Any,
+ valueBytes: Array[Byte],
+ cluster: Cluster
+ )
Review comment:
nit: indent more or less.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org