You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/05 15:03:21 UTC
[GitHub] [incubator-yunikorn-core] adamantal opened a new pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
adamantal opened a new pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214
Reduced the log level from WARN to INFO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on a change in pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#discussion_r499922327
##########
File path: pkg/common/resources/resources.go
##########
@@ -792,7 +792,7 @@ func CalculateAbsUsedCapacity(capacity, used *Resource) *Resource {
absResValue = math.MinInt64
}
} else {
- log.Logger().Warn("Cannot calculate absolute usage for resource because of missing usage information",
+ log.Logger().Info("Cannot calculate absolute usage for resource because of missing usage information",
Review comment:
Today, we are reporting back all resource types, so we constantly see these lines because resource types "pods", "vcore", "ephemeral-storage", "hugepages-1Gi" etc are not tracked in the scheduler. So setting at INFO level won't seem to be enough for this. I'd suggest removing this line.
Or we will need some mechanism to do white-listed resource names, that will introduce bigger changes for which I don't think it is necessary for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-705373688
> I made it DEBUG level, and only display one aggregated log about the every resource that we're missing information about. I hope you will agree with this resolution.
OK, I think this is fine. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] adamantal commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
adamantal commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-704919110
Thanks for the review.
I think it still worth to display the information about the missing resource, but I also agree that this log is too much.
I made it DEBUG level, and only display one aggregated log about the every resource that we're missing information about. I hope you will agree with this resolution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] edited a comment on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-703697275
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/b0f7313570ab5962b28ee1180d5a45bf744cd16e?el=desc) will **decrease** coverage by `0.16%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 60.96% 60.80% -0.17%
==========================================
Files 67 67
Lines 5767 5723 -44
==========================================
- Hits 3516 3480 -36
+ Misses 2109 2102 -7
+ Partials 142 141 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `96.06% <100.00%> (ø)` | |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `50.00% <0.00%> (-3.90%)` | :arrow_down: |
| [pkg/common/configs/configwatcher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3dhdGNoZXIuZ28=) | `83.33% <0.00%> (-1.42%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=footer). Last update [b0f7313...76e179c](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei merged pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
yangwwei merged pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-703697275
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=h1) Report
> Merging [#214](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/1e23202cef2a9bc0798290135ab7570cc4d0a51e?el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `75.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #214 +/- ##
==========================================
- Coverage 60.82% 60.80% -0.03%
==========================================
Files 67 67
Lines 5688 5723 +35
==========================================
+ Hits 3460 3480 +20
- Misses 2087 2102 +15
Partials 141 141
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/queue\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3F1ZXVlX2luZm8uZ28=) | `68.99% <0.00%> (-0.88%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `50.00% <ø> (+2.46%)` | :arrow_up: |
| [pkg/common/configs/config.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `68.96% <100.00%> (ø)` | |
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `86.87% <100.00%> (ø)` | |
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `96.06% <100.00%> (ø)` | |
| [pkg/cache/cachetestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2NhY2hldGVzdHV0aWxzLmdv) | `51.51% <0.00%> (-3.33%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=footer). Last update [29d6c82...1bd0e55](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/214?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-704920222
## Travis tests have failed
Hey @adamantal,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.
### 1st Build
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/jobs/733650794">View build log</a>
<details>
<summary>
<strong>
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.22.2
</strong>
</summary>
```
golangci/golangci-lint info checking GitHub for tag 'v1.22.2'
golangci/golangci-lint info found version: 1.22.2 for v1.22.2/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
```
</details>
<details>
<summary>
<strong>
make lint
</strong>
</summary>
```
running golangci-lint
pkg/common/resources/resources.go:767: File is not `gofmt`-ed with `-s` (gofmt)
missingResources := make([]string, 0)
Makefile:45: recipe for target 'lint' failed
make: *** [lint] Error 1
```
</details>
###### TravisBuddy Request Identifier: 60ea2f20-089d-11eb-9b15-83942378e0dd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-705373688
> I made it DEBUG level, and only display one aggregated log about the every resource that we're missing information about. I hope you will agree with this resolution.
OK, I think this is fine. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-705004785
Hey @adamantal,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/733670803">View build log</a>
###### TravisBuddy Request Identifier: c6f9a2c0-08af-11eb-9b15-83942378e0dd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #214: [YUNIKORN-428] Reduce the warning logs in resources.go
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #214:
URL: https://github.com/apache/incubator-yunikorn-core/pull/214#issuecomment-703697200
Hey @adamantal,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/732995770">View build log</a>
###### TravisBuddy Request Identifier: 324a2ca0-071d-11eb-ae86-23b548ca2017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org