You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/01/24 01:34:21 UTC

[GitHub] astonzhang commented on a change in pull request #9534: Text APIs: interface name change

astonzhang commented on a change in pull request #9534: Text APIs: interface name change
URL: https://github.com/apache/incubator-mxnet/pull/9534#discussion_r163432764
 
 

 ##########
 File path: docs/api/python/text/text.md
 ##########
 @@ -137,14 +137,14 @@ candidate indices may be obtained via
 .. autosummary::
     :nosignatures:
 
-    Glossary
+    CompositeEmbedding
 ```
 
 To get all the valid names for pre-trained embeddings and files, we can use
-[`TokenEmbedding.get_embedding_and_pretrained_file_names`](#mxnet.contrib.text.embedding.TokenEmbedding.get_embedding_and_pretrained_file_names).
+[`_TokenEmbedding.get_embedding_and_pretrained_file_names`](#mxnet.contrib.text.embedding.TokenEmbedding.get_embedding_and_pretrained_file_names).
 
 Review comment:
   Thanks. Although it is possible to shorten it with some alias, I think this name is clearer. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services