You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ma...@apache.org on 2011/05/18 14:16:39 UTC
svn commit: r1124213 - in /myfaces/core/trunk/api/src:
main/java/javax/faces/component/UIComponentBase.java
test/java/javax/faces/component/UIComponentBaseTest.java
Author: martinkoci
Date: Wed May 18 12:16:39 2011
New Revision: 1124213
URL: http://svn.apache.org/viewvc?rev=1124213&view=rev
Log:
MYFACES-3136 [perf] review UIComponentBase.getRendererType
Modified:
myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
myfaces/core/trunk/api/src/test/java/javax/faces/component/UIComponentBaseTest.java
Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java?rev=1124213&r1=1124212&r2=1124213&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java Wed May 18 12:16:39 2011
@@ -897,7 +897,8 @@ public abstract class UIComponentBase ex
@Override
public String getRendererType()
{
- return (String) getStateHelper().eval(PropertyKeys.rendererType);
+ // rendererType is literal-only, no ValueExpression - MYFACES-3136:
+ return (String) getStateHelper().get(PropertyKeys.rendererType);
}
/**
Modified: myfaces/core/trunk/api/src/test/java/javax/faces/component/UIComponentBaseTest.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/test/java/javax/faces/component/UIComponentBaseTest.java?rev=1124213&r1=1124212&r2=1124213&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/test/java/javax/faces/component/UIComponentBaseTest.java (original)
+++ myfaces/core/trunk/api/src/test/java/javax/faces/component/UIComponentBaseTest.java Wed May 18 12:16:39 2011
@@ -405,7 +405,7 @@ public class UIComponentBaseTest
{
return getMocksControl().createMock(UIComponentBase.class, new Method[0]);
}
- }, new AbstractUIComponentPropertyTest<String>("rendererType", null, new String[] { "xyz", "abc" })
+ }, new AbstractUIComponentPropertyTest<String>("rendererType", null, new String[] { null, null })
{
@Override
protected UIComponent createComponent()