[GitHub] [flink] bowenli86 commented on a change in pull request #10394: [FLINK-14663]Distinguish catalogColumnStats' unknown value and real values

[GitBox <gi...@apache.org>]

bowenli86 commented on a change in pull request #10394: [FLINK-14663]Distinguish catalogColumnStats' unknown  value and real values
URL: https://github.com/apache/flink/pull/10394#discussion_r353360331
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveStatsUtil.java
 ##########
 @@ -189,16 +189,37 @@ private static ColumnStatisticsData getColumnStatisticsData(DataType colType, Ca
 		|| type.equals(LogicalTypeRoot.VARCHAR)) {
 			if (colStat instanceof CatalogColumnStatisticsDataString) {
 				CatalogColumnStatisticsDataString stringColStat = (CatalogColumnStatisticsDataString) colStat;
-				return ColumnStatisticsData.stringStats(new StringColumnStatsData(stringColStat.getMaxLength(), stringColStat.getAvgLength(), stringColStat.getNullCount(), stringColStat.getNdv()));
+				StringColumnStatsData hiveStringColumnStats = new StringColumnStatsData();
+				hiveStringColumnStats.clear();
+				if (null != stringColStat.getMaxLength()) {
+					hiveStringColumnStats.setMaxColLen(stringColStat.getMaxLength());
+				}
+				if (null != stringColStat.getAvgLength()) {
+					hiveStringColumnStats.setAvgColLen(stringColStat.getAvgLength());
+				}
+				if (null != stringColStat.getNullCount()) {
+					hiveStringColumnStats.setNumNulls(stringColStat.getNullCount());
+				}
+				if (null != stringColStat.getNdv()) {
+					hiveStringColumnStats.setNumDVs(stringColStat.getNdv());
+				}
+				return ColumnStatisticsData.stringStats(hiveStringColumnStats);
 			}
 		} else if (type.equals(LogicalTypeRoot.BOOLEAN)) {
 			if (colStat instanceof CatalogColumnStatisticsDataBoolean) {
 				CatalogColumnStatisticsDataBoolean booleanColStat = (CatalogColumnStatisticsDataBoolean) colStat;
-				BooleanColumnStatsData boolStats = new BooleanColumnStatsData(
-						booleanColStat.getTrueCount(),
-						booleanColStat.getFalseCount(),
-						booleanColStat.getNullCount());
-				return ColumnStatisticsData.booleanStats(boolStats);
+				BooleanColumnStatsData hiveBoolStats = new BooleanColumnStatsData();
+				hiveBoolStats.clear();
+				if (null != booleanColStat.getTrueCount()) {
+					hiveBoolStats.setNumTrues(booleanColStat.getTrueCount());
+				}
+				if (null != booleanColStat.getFalseCount()) {
+					hiveBoolStats.setNumFalses(booleanColStat.getFalseCount());
+				}
+				if (null != booleanColStat.getNullCount()) {
+					hiveBoolStats.setNumNulls(booleanColStat.getTrueCount());
 
 Review comment:
   ```suggestion
   					hiveBoolStats.setNumNulls(booleanColStat.getNullCount());
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services