You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/08/03 20:17:49 UTC
Review Request 61414: Patch/Service Downgrades Are Not Correctly
Scoped
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61414/
-----------------------------------------------------------
Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-21656
https://issues.apache.org/jira/browse/AMBARI-21656
Repository: ambari
Description
-------
When creating a downgrade from either a {{PATCH}} or {{SERVICE}} upgrade, the following is observed:
- Things like "set version on all hosts" runs
- The upgrade "services" structure is empty, indicating an entire cluster is being downgraded
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 629f3cd771
ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java 215cab85cf
ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 8bf0400753
Diff: https://reviews.apache.org/r/61414/diff/1/
Testing
-------
PENDING... still need to write the UTs to cover the UpgradeContext being initialized correctly on DOWNGRADE.
Thanks,
Jonathan Hurley
Re: Review Request 61414: Patch/Service Downgrades Are Not Correctly
Scoped
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61414/#review182170
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Aug. 3, 2017, 8:17 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61414/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 8:17 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-21656
> https://issues.apache.org/jira/browse/AMBARI-21656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When creating a downgrade from either a {{PATCH}} or {{SERVICE}} upgrade, the following is observed:
>
> - Things like "set version on all hosts" runs
> - The upgrade "services" structure is empty, indicating an entire cluster is being downgraded
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 629f3cd771
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java 215cab85cf
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 8bf0400753
>
>
> Diff: https://reviews.apache.org/r/61414/diff/1/
>
>
> Testing
> -------
>
> PENDING... still need to write the UTs to cover the UpgradeContext being initialized correctly on DOWNGRADE.
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 61414: Patch/Service Downgrades Are Not Correctly
Scoped
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61414/#review182192
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 3, 2017, 11:17 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61414/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2017, 11:17 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-21656
> https://issues.apache.org/jira/browse/AMBARI-21656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When creating a downgrade from either a {{PATCH}} or {{SERVICE}} upgrade, the following is observed:
>
> - Things like "set version on all hosts" runs
> - The upgrade "services" structure is empty, indicating an entire cluster is being downgraded
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java 629f3cd771
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryType.java 215cab85cf
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java 8bf0400753
>
>
> Diff: https://reviews.apache.org/r/61414/diff/1/
>
>
> Testing
> -------
>
> PENDING... still need to write the UTs to cover the UpgradeContext being initialized correctly on DOWNGRADE.
>
>
> Thanks,
>
> Jonathan Hurley
>
>