[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1631: SOLR-14599: Package manager support for cluster level plugins

[GitBox <gi...@apache.org>]

dsmiley commented on a change in pull request #1631:
URL: https://github.com/apache/lucene-solr/pull/1631#discussion_r450609479



##########
File path: solr/core/src/java/org/apache/solr/util/PackageTool.java
##########
@@ -149,7 +149,8 @@ protected void runImpl(CommandLine cli) throws Exception {
                 String version = parsedVersion.second();
                 boolean noprompt = cli.hasOption('y');
                 boolean isUpdate = cli.hasOption("update") || cli.hasOption('u');
-                packageManager.deploy(packageName, version, PackageUtils.validateCollections(cli.getOptionValue("collections").split(",")), cli.getOptionValues("param"), isUpdate, noprompt);
+                String collections[] = cli.hasOption("collections")? PackageUtils.validateCollections(cli.getOptionValue("collections").split(",")): new String[] {};

Review comment:
       Please don't use C-style array declarations.  IMO our pre-commit ought to be enhanced to not allow this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org