You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/05 06:40:08 UTC
[GitHub] [maven-dependency-analyzer] josephw opened a new pull request #44: Mdep 779 include class names in used undeclared dependencies
josephw opened a new pull request #44:
URL: https://github.com/apache/maven-dependency-analyzer/pull/44
It would be useful, when debugging failure of `dependency:analyze` if it were easy to see the specific classes that caused that dependency to be used. This change introduces that functionality in the underlying `maven-dependency-analyzer` library, with the intention of exposing it in the plugin (through an opt-in flag?).
It intentionally keeps binary compatibility for the classes involved, and includes a new test to demonstrate the behaviour.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSHARED) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes. Also be sure having selected the correct component.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[MSHARED-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MSHARED-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] josephw commented on pull request #44: MDEP-779: include class names in used undeclared dependencies
Posted by GitBox <gi...@apache.org>.
josephw commented on pull request #44:
URL: https://github.com/apache/maven-dependency-analyzer/pull/44#issuecomment-986208808
I've just realised that this is almost exactly the same functionality as #20 . If I'm interested in having this available in `dependency:analyze`, should I follow up on this PR, or look at resolving the merge conflicts for the other one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-dependency-analyzer] slachiewicz merged pull request #44: MDEP-779: include class names in used undeclared dependencies
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #44:
URL: https://github.com/apache/maven-dependency-analyzer/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org