[GitHub] spark pull request #23128: [SPARK-26142][SQL] Support passing shuffle metric...

[rxin <gi...@git.apache.org>]

Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23128#discussion_r236025817
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLShuffleMetricsReporter.scala ---
    @@ -0,0 +1,60 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.metric
    +
    +import org.apache.spark.executor.TempShuffleReadMetrics
    +
    +/**
    + * A shuffle metrics reporter for SQL exchange operators.
    + * @param tempMetrics [[TempShuffleReadMetrics]] created in TaskContext.
    + * @param metrics All metrics in current SparkPlan.
    + */
    +class SQLShuffleMetricsReporter(
    +  tempMetrics: TempShuffleReadMetrics,
    +  metrics: Map[String, SQLMetric]) extends TempShuffleReadMetrics {
    +
    +  override def incRemoteBlocksFetched(v: Long): Unit = {
    +    metrics(SQLMetrics.REMOTE_BLOCKS_FETCHED).add(v)
    --- End diff --
    
    Doing a hashmap lookup here could introduce serious performance regressions.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org