You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by andralungu <gi...@git.apache.org> on 2015/04/26 20:20:22 UTC
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/625
[gelly][Refactoring] Removed example string
@vasia,
Just FYI :), in example/utils we have a class EdgeWithLongIdNullValueParser that is never used.
The examples that correspond to the library methods, e.g. PageRankExample cannot be renamed because that will cause a collision with the method name, in this case, PageRank. I guess that's why we added "Example" to the class name in the first place.
To me the examples look good as they are in this commit. If you have another idea for the library method examples, let me know, but in my view Example is better than Usage, or whatever different word we may come up with.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andralungu/flink examples
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #625
----
commit d6414eae54a2bafdba4457ffb2aa0bd1d34ad57d
Author: andralungu <lu...@gmail.com>
Date: 2015-04-26T18:09:04Z
[gelly][Refactoring] Removed example string
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/625#issuecomment-102373199
Hi @andralungu,
regarding `EdgeWithLongIdNullValueParser`: good catch, let's remove it then.
As for the renaming, I would like the examples naming to be consistent. Right now, we have some named `xyzExample` like `GSAConnectedComponentsExample` and others without "Example" in the end, like `GSAPageRank`. I personally don't like "Example" in the end, because it makes class names unnecessarily long (we already know they're examples since they're in the respective package).
For the ones that don't use a library method, this is no problem. For the ones that use a library method and we have a collision. I guess we have two choices: (a) keep the word "Example" for the ones using a library method or (b) renaming the library methods to something like `xzyAlgorithm`.
Any other ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/625#issuecomment-103641540
I take it your update means you agreed with my suggestion :)
I'll merge this one as well!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/625#issuecomment-102376105
If you don't like the example string at the end, then we can go for sol (b)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/625#issuecomment-99499311
@vasia
Don't forget to also have a look at this PR. It's rebased :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [gelly][Refactoring] Removed example string
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/625#issuecomment-102684206
PR updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---