You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/29 08:05:53 UTC
[GitHub] [apisix-dashboard] imjoey opened a new issue #1145: bug(Dockerfile): use the code from master branch for building docker image
imjoey opened a new issue #1145:
URL: https://github.com/apache/apisix-dashboard/issues/1145
# Bug report
## Describe the bug
The `Dockerfile` in master branch seems using the code from a specific release for building docker image. I guess we should fetch the code from master branch in `Dockerfile` defined in master branch. The code from a release can only be used in a `Dockerfile` defined in corresponding release.
Any feedback is welcome. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1145: bug(Dockerfile): use the code from master branch for building docker image
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1145:
URL: https://github.com/apache/apisix-dashboard/issues/1145#issuecomment-752047930
Since https://github.com/apache/apisix-dashboard/pull/1146 and https://github.com/apache/apisix-docker/pull/108 are already merged, I would say this issue has been fixed. Will close this. Please reopen this if anything is unexpected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey closed issue #1145: bug(Dockerfile): use the code from master branch for building docker image
Posted by GitBox <gi...@apache.org>.
imjoey closed issue #1145:
URL: https://github.com/apache/apisix-dashboard/issues/1145
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1145: bug(Dockerfile): use the code from master branch for building docker image
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1145:
URL: https://github.com/apache/apisix-dashboard/issues/1145#issuecomment-751993618
I've proposed a PR #1146 to fix this. Feel free to review, only if we can reach a consensus. Much appreciated. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1145: bug(Dockerfile): use the code from master branch for building docker image
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1145:
URL: https://github.com/apache/apisix-dashboard/issues/1145#issuecomment-752047930
Since https://github.com/apache/apisix-dashboard/pull/1146 and https://github.com/apache/apisix-docker/pull/108 are already merged, I would say this issue has been fixed. Will close this. Feel free to reopen this if anything is unexpected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org