You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2023/02/16 01:45:27 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #29563: Improve grid view height calculations
bbovenzi opened a new pull request, #29563:
URL: https://github.com/apache/airflow/pull/29563
In https://github.com/apache/airflow/pull/29367 I address the issue of the grid view heights being too short simply by doubling the minimum height. This PR tries to come up with a better solution. Instead of calculating the window height and a top/bottom offset, we simply sit a maxHeight for the parent component of the entire grid view and then subtract the topOffset of each component that needs a scroll overflow.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #29563: Improve grid view height calculations
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #29563:
URL: https://github.com/apache/airflow/pull/29563#discussion_r1114594299
##########
airflow/www/static/css/main.css:
##########
@@ -19,7 +19,7 @@
body {
position: relative;
- padding: 70px 0 100px;
Review Comment:
We don't need such large bottom padding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29563: Improve grid view height calculations
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29563:
URL: https://github.com/apache/airflow/pull/29563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org