You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "prakharcode (via GitHub)" <gi...@apache.org> on 2025/09/24 14:59:15 UTC
[PR] [fix]: Creating an explicit control for createUserJob [airflow]
prakharcode opened a new pull request, #56057:
URL: https://github.com/apache/airflow/pull/56057
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
closes: #51304
As describe in the issue, the createUserJob fails on the new standalone installation on helm.
This is because the createUserJob only checks in the setting for `defaultUser.enabled` in webserver. This setting is while being perfectly fine for older versions of airflow, created a bit of confusion for newer versions (specially ones which are trying to deploy with simple_auth).
To make the creation of `createUserJob` explicit, I have included another value which explicitly sets `enabled: true | false`.
This should make things clear and init control (a bit) independent.
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3577290911
@prakharcode to me the change looks good now.
@jedcunningham @hussein-awala @jscheffl could you take a look in a free moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "prakharcode (via GitHub)" <gi...@apache.org>.
prakharcode commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3371431735
@jedcunningham can you take a look here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #56057:
URL: https://github.com/apache/airflow/pull/56057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "Miretpl (via GitHub)" <gi...@apache.org>.
Miretpl commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3618682219
@prakharcode I can't do much more, really, cause I'm not able to merge the change to the repository. Just be patient till one of the PMC members takes a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "prakharcode (via GitHub)" <gi...@apache.org>.
prakharcode commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3333993280
@hussein-awala can you take a look here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "prakharcode (via GitHub)" <gi...@apache.org>.
prakharcode commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3556722491
@Miretpl I will add a test for it today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Create an explicit control for createUserJob [airflow]
Posted by "prakharcode (via GitHub)" <gi...@apache.org>.
prakharcode commented on PR #56057:
URL: https://github.com/apache/airflow/pull/56057#issuecomment-3616998142
@Miretpl @jedcunningham @jscheffl can we move the PR forward?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org