You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/26 19:58:32 UTC
svn commit: r1697982 - in /commons/proper/bcel/trunk/src: changes/
main/java/org/apache/commons/bcel6/generic/
Author: sebb
Date: Wed Aug 26 17:58:31 2015
New Revision: 1697982
URL: http://svn.apache.org/r1697982
Log:
BCEL-257 INVOKESPECIAL, INVOKESTATIC, INVOKEVIRTUAL need to define dump() methods
Modified:
commons/proper/bcel/trunk/src/changes/changes.xml
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESPECIAL.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESTATIC.java
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKEVIRTUAL.java
Modified: commons/proper/bcel/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/changes/changes.xml?rev=1697982&r1=1697981&r2=1697982&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/changes/changes.xml (original)
+++ commons/proper/bcel/trunk/src/changes/changes.xml Wed Aug 26 17:58:31 2015
@@ -63,6 +63,7 @@ The <action> type attribute can be add,u
<body>
<release version="6.0" date="TBA" description="Major release with Java 7 and 8 support">
+ <action issue="BCEL-257" type="fix">INVOKESPECIAL, INVOKESTATIC, INVOKEVIRTUAL need to define dump() methods</action>
<action issue="BCEL-254" type="fix">Two more methods that would be nice to be public.</action>
<action issue="BCEL-245" type="fix">Type class includes constants that reference subclasses</action>
<action issue="BCEL-253" type="fix">Pass 3b verifier is too strict.</action>
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESPECIAL.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESPECIAL.java?rev=1697982&r1=1697981&r2=1697982&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESPECIAL.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESPECIAL.java Wed Aug 26 17:58:31 2015
@@ -17,6 +17,9 @@
*/
package org.apache.commons.bcel6.generic;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
import org.apache.commons.bcel6.Constants;
import org.apache.commons.bcel6.ExceptionConstants;
@@ -46,6 +49,16 @@ public class INVOKESPECIAL extends Invok
}
+ /**
+ * Dump instruction as byte code to stream out.
+ * @param out Output stream
+ */
+ @Override
+ public void dump( DataOutputStream out ) throws IOException {
+ out.writeByte(super.getOpcode());
+ out.writeShort(super.getIndex());
+ }
+
@Override
public Class<?>[] getExceptions() {
return ExceptionConstants.createExceptions(ExceptionConstants.EXCS.EXCS_FIELD_AND_METHOD_RESOLUTION,
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESTATIC.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESTATIC.java?rev=1697982&r1=1697981&r2=1697982&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESTATIC.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKESTATIC.java Wed Aug 26 17:58:31 2015
@@ -17,6 +17,9 @@
*/
package org.apache.commons.bcel6.generic;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
import org.apache.commons.bcel6.Constants;
import org.apache.commons.bcel6.ExceptionConstants;
@@ -45,6 +48,16 @@ public class INVOKESTATIC extends Invoke
}
+ /**
+ * Dump instruction as byte code to stream out.
+ * @param out Output stream
+ */
+ @Override
+ public void dump( DataOutputStream out ) throws IOException {
+ out.writeByte(super.getOpcode());
+ out.writeShort(super.getIndex());
+ }
+
@Override
public Class<?>[] getExceptions() {
return ExceptionConstants.createExceptions(ExceptionConstants.EXCS.EXCS_FIELD_AND_METHOD_RESOLUTION,
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKEVIRTUAL.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKEVIRTUAL.java?rev=1697982&r1=1697981&r2=1697982&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKEVIRTUAL.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/INVOKEVIRTUAL.java Wed Aug 26 17:58:31 2015
@@ -17,6 +17,9 @@
*/
package org.apache.commons.bcel6.generic;
+import java.io.DataOutputStream;
+import java.io.IOException;
+
import org.apache.commons.bcel6.Constants;
import org.apache.commons.bcel6.ExceptionConstants;
@@ -45,6 +48,16 @@ public class INVOKEVIRTUAL extends Invok
}
+ /**
+ * Dump instruction as byte code to stream out.
+ * @param out Output stream
+ */
+ @Override
+ public void dump( DataOutputStream out ) throws IOException {
+ out.writeByte(super.getOpcode());
+ out.writeShort(super.getIndex());
+ }
+
@Override
public Class<?>[] getExceptions() {
return ExceptionConstants.createExceptions(ExceptionConstants.EXCS.EXCS_FIELD_AND_METHOD_RESOLUTION,