You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Bryan Duxbury <br...@rapleaf.com> on 2011/01/27 00:10:19 UTC
[VOTE] Thrift 0.6.0 RC1
All,
I propose that we accept
http://people.apache.org/~bryanduxbury/thrift-0.6.0-rc1.tar.gz<http://people.apache.org/%7Ebryanduxbury/thrift-0.6.0-rc1.tar.gz>as
the official Thrift 0.6.0 release. This will be our first release
since
we graduated from the incubator.
I generated this tarball by checking out
https://svn.apache.org/repos/asf/thrift/branches/0.6.x and running
"./bootstrap.sh && ./configure && make dist". It incorporates a handful of
fixes to the build and to a critical Java issue found by Mathias.
The GPG signature can be found at
http://people.apache.org/~bryanduxbury/thrift-0.6.0-rc1.tar.gz.asc<http://people.apache.org/%7Ebryanduxbury/thrift-0.6.0-rc1.tar.gz.asc>.
It has an MD5 sum of c97458ded29281e39d2ad9df6aa00ee6.
Please download, verify sig/sum, and install/test the libraries of your
choice.
This vote closes in 72 hours.
RE: [VOTE] Thrift 0.6.0 RC1
Posted by Mark Slee <ms...@fb.com>.
I only fixed a misplaced @Override in the library implementation. This issue (633) deals with @Override annotations in the generated code -- which I did not address. So that one's still outstanding.
-----Original Message-----
From: Mathias Herberts [mailto:mathias.herberts@gmail.com]
Sent: Friday, January 28, 2011 9:08 PM
To: dev@thrift.apache.org
Subject: Re: [VOTE] Thrift 0.6.0 RC1
Mark,
this issue looks like
https://issues.apache.org/jira/browse/THRIFT-633, did you patch all
occurrences of misplaced @Override? In this case I guess THRIFT-633
could be closed too.
I currently don't have a 1.5 handy on OS X to check.
On Fri, Jan 28, 2011 at 23:27, Mark Slee <ms...@fb.com> wrote:
> Ticket opened and patch committed to trunk. Ready for a merge into the 0.6 release.
>
> https://issues.apache.org/jira/browse/THRIFT-1051
> Committed revision 1064911.
>
> Cheers,
> mcslee
>
> -----Original Message-----
> From: Bryan Duxbury [mailto:bryan@rapleaf.com]
> Sent: Friday, January 28, 2011 2:17 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>
> Mind opening a ticket?
>
> On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote:
>
>> -1, just a minor issue. I'm +1 if we nuke the @Override causing problems
>> below.
>>
>> The Java compile failed for me due to a bad @Override annotation on an
>> interface rather than an abstract class. I'm running Java 1.5. According to
>> Stack Overflow:
>>
>> "But don't forget that Java Compiler 1.5 will not allow this annotation
>> when overriding interface methods... Some IDEs, as Eclipse, even configured
>> with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 and
>> don't allow the use @override as described above."
>>
>> compile:
>> [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
>> [javac]
>> /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186:
>> method does not override a method from its superclass
>> [javac] @Override
>> [javac] ^
>> [javac] Note: Some input files use unchecked or unsafe operations.
>> [javac] Note: Recompile with -Xlint:unchecked for details.
>> [javac] 1 error
>>
>> BUILD FAILED
>> /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the compiler
>> error output for details.
>>
>> This is the code in question -- I think we should nuke this @Override to
>> ensure the project builds on Java 1.5. Everything else looks fine.
>>
>> /** Comparator used in TreeSet */
>> private static class TAsyncMethodCallTimeoutComparator implements
>> Comparator<TAsyncMethodCall> {
>> @Override
>> public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
>>
>>
>> -----Original Message-----
>> From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
>> Sent: Thursday, January 27, 2011 7:55 PM
>> To: dev@thrift.apache.org
>> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>>
>> +1
>>
>> Haskell works, and the whole thing compiles (and make checks) on Mac OS X
>> 10.6.
>>
>> On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
>> <ma...@gmail.com> wrote:
>> > +1
>> >
>> > My GWT patch was successfully updated for this RC.
>> >
>>
>>
>>
>> --
>> Have fun, Christian
>> http://linkedin.christianlavoie.net
>>
>> "I won't let you fall apart."
>>
>
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Mathias Herberts <ma...@gmail.com>.
Mark,
this issue looks like
https://issues.apache.org/jira/browse/THRIFT-633, did you patch all
occurrences of misplaced @Override? In this case I guess THRIFT-633
could be closed too.
I currently don't have a 1.5 handy on OS X to check.
On Fri, Jan 28, 2011 at 23:27, Mark Slee <ms...@fb.com> wrote:
> Ticket opened and patch committed to trunk. Ready for a merge into the 0.6 release.
>
> https://issues.apache.org/jira/browse/THRIFT-1051
> Committed revision 1064911.
>
> Cheers,
> mcslee
>
> -----Original Message-----
> From: Bryan Duxbury [mailto:bryan@rapleaf.com]
> Sent: Friday, January 28, 2011 2:17 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>
> Mind opening a ticket?
>
> On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote:
>
>> -1, just a minor issue. I'm +1 if we nuke the @Override causing problems
>> below.
>>
>> The Java compile failed for me due to a bad @Override annotation on an
>> interface rather than an abstract class. I'm running Java 1.5. According to
>> Stack Overflow:
>>
>> "But don't forget that Java Compiler 1.5 will not allow this annotation
>> when overriding interface methods... Some IDEs, as Eclipse, even configured
>> with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 and
>> don't allow the use @override as described above."
>>
>> compile:
>> [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
>> [javac]
>> /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186:
>> method does not override a method from its superclass
>> [javac] @Override
>> [javac] ^
>> [javac] Note: Some input files use unchecked or unsafe operations.
>> [javac] Note: Recompile with -Xlint:unchecked for details.
>> [javac] 1 error
>>
>> BUILD FAILED
>> /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the compiler
>> error output for details.
>>
>> This is the code in question -- I think we should nuke this @Override to
>> ensure the project builds on Java 1.5. Everything else looks fine.
>>
>> /** Comparator used in TreeSet */
>> private static class TAsyncMethodCallTimeoutComparator implements
>> Comparator<TAsyncMethodCall> {
>> @Override
>> public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
>>
>>
>> -----Original Message-----
>> From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
>> Sent: Thursday, January 27, 2011 7:55 PM
>> To: dev@thrift.apache.org
>> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>>
>> +1
>>
>> Haskell works, and the whole thing compiles (and make checks) on Mac OS X
>> 10.6.
>>
>> On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
>> <ma...@gmail.com> wrote:
>> > +1
>> >
>> > My GWT patch was successfully updated for this RC.
>> >
>>
>>
>>
>> --
>> Have fun, Christian
>> http://linkedin.christianlavoie.net
>>
>> "I won't let you fall apart."
>>
>
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Jake Luciani <ja...@gmail.com>.
-1 I'll re-roll with the changes mentioned below plus a critical performance
bug in c# that should go out.
On Fri, Jan 28, 2011 at 5:27 PM, Mark Slee <ms...@fb.com> wrote:
> Ticket opened and patch committed to trunk. Ready for a merge into the 0.6
> release.
>
> https://issues.apache.org/jira/browse/THRIFT-1051
> Committed revision 1064911.
>
> Cheers,
> mcslee
>
> -----Original Message-----
> From: Bryan Duxbury [mailto:bryan@rapleaf.com]
> Sent: Friday, January 28, 2011 2:17 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>
> Mind opening a ticket?
>
> On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote:
>
> > -1, just a minor issue. I'm +1 if we nuke the @Override causing problems
> > below.
> >
> > The Java compile failed for me due to a bad @Override annotation on an
> > interface rather than an abstract class. I'm running Java 1.5. According
> to
> > Stack Overflow:
> >
> > "But don't forget that Java Compiler 1.5 will not allow this annotation
> > when overriding interface methods... Some IDEs, as Eclipse, even
> configured
> > with Java 1.6 runtime or higher, they maintain compliance with Java 1.5
> and
> > don't allow the use @override as described above."
> >
> > compile:
> > [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
> > [javac]
> >
> /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186:
> > method does not override a method from its superclass
> > [javac] @Override
> > [javac] ^
> > [javac] Note: Some input files use unchecked or unsafe operations.
> > [javac] Note: Recompile with -Xlint:unchecked for details.
> > [javac] 1 error
> >
> > BUILD FAILED
> > /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the
> compiler
> > error output for details.
> >
> > This is the code in question -- I think we should nuke this @Override to
> > ensure the project builds on Java 1.5. Everything else looks fine.
> >
> > /** Comparator used in TreeSet */
> > private static class TAsyncMethodCallTimeoutComparator implements
> > Comparator<TAsyncMethodCall> {
> > @Override
> > public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
> >
> >
> > -----Original Message-----
> > From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
> > Sent: Thursday, January 27, 2011 7:55 PM
> > To: dev@thrift.apache.org
> > Subject: Re: [VOTE] Thrift 0.6.0 RC1
> >
> > +1
> >
> > Haskell works, and the whole thing compiles (and make checks) on Mac OS X
> > 10.6.
> >
> > On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
> > <ma...@gmail.com> wrote:
> > > +1
> > >
> > > My GWT patch was successfully updated for this RC.
> > >
> >
> >
> >
> > --
> > Have fun, Christian
> > http://linkedin.christianlavoie.net
> >
> > "I won't let you fall apart."
> >
>
RE: [VOTE] Thrift 0.6.0 RC1
Posted by Mark Slee <ms...@fb.com>.
Ticket opened and patch committed to trunk. Ready for a merge into the 0.6 release.
https://issues.apache.org/jira/browse/THRIFT-1051
Committed revision 1064911.
Cheers,
mcslee
-----Original Message-----
From: Bryan Duxbury [mailto:bryan@rapleaf.com]
Sent: Friday, January 28, 2011 2:17 PM
To: dev@thrift.apache.org
Subject: Re: [VOTE] Thrift 0.6.0 RC1
Mind opening a ticket?
On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote:
> -1, just a minor issue. I'm +1 if we nuke the @Override causing problems
> below.
>
> The Java compile failed for me due to a bad @Override annotation on an
> interface rather than an abstract class. I'm running Java 1.5. According to
> Stack Overflow:
>
> "But don't forget that Java Compiler 1.5 will not allow this annotation
> when overriding interface methods... Some IDEs, as Eclipse, even configured
> with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 and
> don't allow the use @override as described above."
>
> compile:
> [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
> [javac]
> /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186:
> method does not override a method from its superclass
> [javac] @Override
> [javac] ^
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 error
>
> BUILD FAILED
> /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the compiler
> error output for details.
>
> This is the code in question -- I think we should nuke this @Override to
> ensure the project builds on Java 1.5. Everything else looks fine.
>
> /** Comparator used in TreeSet */
> private static class TAsyncMethodCallTimeoutComparator implements
> Comparator<TAsyncMethodCall> {
> @Override
> public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
>
>
> -----Original Message-----
> From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
> Sent: Thursday, January 27, 2011 7:55 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>
> +1
>
> Haskell works, and the whole thing compiles (and make checks) on Mac OS X
> 10.6.
>
> On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
> <ma...@gmail.com> wrote:
> > +1
> >
> > My GWT patch was successfully updated for this RC.
> >
>
>
>
> --
> Have fun, Christian
> http://linkedin.christianlavoie.net
>
> "I won't let you fall apart."
>
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Bryan Duxbury <br...@rapleaf.com>.
Mind opening a ticket?
On Fri, Jan 28, 2011 at 2:05 PM, Mark Slee <ms...@fb.com> wrote:
> -1, just a minor issue. I'm +1 if we nuke the @Override causing problems
> below.
>
> The Java compile failed for me due to a bad @Override annotation on an
> interface rather than an abstract class. I'm running Java 1.5. According to
> Stack Overflow:
>
> "But don't forget that Java Compiler 1.5 will not allow this annotation
> when overriding interface methods... Some IDEs, as Eclipse, even configured
> with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 and
> don't allow the use @override as described above."
>
> compile:
> [javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
> [javac]
> /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186:
> method does not override a method from its superclass
> [javac] @Override
> [javac] ^
> [javac] Note: Some input files use unchecked or unsafe operations.
> [javac] Note: Recompile with -Xlint:unchecked for details.
> [javac] 1 error
>
> BUILD FAILED
> /tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the compiler
> error output for details.
>
> This is the code in question -- I think we should nuke this @Override to
> ensure the project builds on Java 1.5. Everything else looks fine.
>
> /** Comparator used in TreeSet */
> private static class TAsyncMethodCallTimeoutComparator implements
> Comparator<TAsyncMethodCall> {
> @Override
> public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
>
>
> -----Original Message-----
> From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
> Sent: Thursday, January 27, 2011 7:55 PM
> To: dev@thrift.apache.org
> Subject: Re: [VOTE] Thrift 0.6.0 RC1
>
> +1
>
> Haskell works, and the whole thing compiles (and make checks) on Mac OS X
> 10.6.
>
> On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
> <ma...@gmail.com> wrote:
> > +1
> >
> > My GWT patch was successfully updated for this RC.
> >
>
>
>
> --
> Have fun, Christian
> http://linkedin.christianlavoie.net
>
> "I won't let you fall apart."
>
RE: [VOTE] Thrift 0.6.0 RC1
Posted by Mark Slee <ms...@fb.com>.
-1, just a minor issue. I'm +1 if we nuke the @Override causing problems below.
The Java compile failed for me due to a bad @Override annotation on an interface rather than an abstract class. I'm running Java 1.5. According to Stack Overflow:
"But don't forget that Java Compiler 1.5 will not allow this annotation when overriding interface methods... Some IDEs, as Eclipse, even configured with Java 1.6 runtime or higher, they maintain compliance with Java 1.5 and don't allow the use @override as described above."
compile:
[javac] Compiling 80 source files to /tmp/thrift-0.6.0/lib/java/build
[javac] /tmp/thrift-0.6.0/lib/java/src/org/apache/thrift/async/TAsyncClientManager.java:186: method does not override a method from its superclass
[javac] @Override
[javac] ^
[javac] Note: Some input files use unchecked or unsafe operations.
[javac] Note: Recompile with -Xlint:unchecked for details.
[javac] 1 error
BUILD FAILED
/tmp/thrift-0.6.0/lib/java/build.xml:137: Compile failed; see the compiler error output for details.
This is the code in question -- I think we should nuke this @Override to ensure the project builds on Java 1.5. Everything else looks fine.
/** Comparator used in TreeSet */
private static class TAsyncMethodCallTimeoutComparator implements Comparator<TAsyncMethodCall> {
@Override
public int compare(TAsyncMethodCall left, TAsyncMethodCall right) {
-----Original Message-----
From: Christian Lavoie [mailto:christian.lavoie@gmail.com]
Sent: Thursday, January 27, 2011 7:55 PM
To: dev@thrift.apache.org
Subject: Re: [VOTE] Thrift 0.6.0 RC1
+1
Haskell works, and the whole thing compiles (and make checks) on Mac OS X 10.6.
On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
<ma...@gmail.com> wrote:
> +1
>
> My GWT patch was successfully updated for this RC.
>
--
Have fun, Christian
http://linkedin.christianlavoie.net
"I won't let you fall apart."
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Christian Lavoie <ch...@gmail.com>.
+1
Haskell works, and the whole thing compiles (and make checks) on Mac OS X 10.6.
On Thu, Jan 27, 2011 at 5:36 PM, Mathias Herberts
<ma...@gmail.com> wrote:
> +1
>
> My GWT patch was successfully updated for this RC.
>
--
Have fun, Christian
http://linkedin.christianlavoie.net
"I won't let you fall apart."
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Mathias Herberts <ma...@gmail.com>.
+1
My GWT patch was successfully updated for this RC.
Re: [VOTE] Thrift 0.6.0 RC1
Posted by Wade Simmons <ws...@gmail.com>.
Bryan,
I submitted four patches for the Node.js support last week that have
been merged to trunk. Without these patches, the implementation has a
lot of flaws. I think it would be nice to get this merged in to the
0.6.0 branch so that the first release of Node.js support doesn't go
out the door with known issues.
- https://issues.apache.org/jira/browse/THRIFT-1042
- https://issues.apache.org/jira/browse/THRIFT-1043
- https://issues.apache.org/jira/browse/THRIFT-1044
- https://issues.apache.org/jira/browse/THRIFT-1045
Thanks,
Wade
--
Wade Simmons <ws...@gmail.com>