You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/31 12:29:49 UTC
[jira] [Commented] (CB-10286) Make geolocation tests use device
plugin to properly detect Android suimulator
[ https://issues.apache.org/jira/browse/CB-10286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15075906#comment-15075906 ]
ASF GitHub Bot commented on CB-10286:
-------------------------------------
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/65
CB-10286 Don't skip automatic tests on Android devices
https://issues.apache.org/jira/browse/CB-10286
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-geolocation CB-10286
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-geolocation/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit f184443eb6694fddfe1d740998e3003a84b86360
Author: Alexander Sorokin <al...@akvelon.com>
Date: 2015-12-31T11:26:33Z
CB-10286 Don't skip automatic tests on Android devices
----
> Make geolocation tests use device plugin to properly detect Android suimulator
> ------------------------------------------------------------------------------
>
> Key: CB-10286
> URL: https://issues.apache.org/jira/browse/CB-10286
> Project: Apache Cordova
> Issue Type: Task
> Components: Android, Plugin Geolocation
> Reporter: Alexander Sorokin
> Assignee: Alexander Sorokin
>
> Most of automatic geolocation tests were pended on Android because we didn't have the tool to detect if the tests are running on a simulator or on a real device.
> Now we have device.isVirtual and can use it to pend the tests only on an emulator.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org