You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/10/19 22:34:43 UTC
[PR] fix(alerts): discard imports from abandoned domain pages [rocketmq-dashboard]
zmuxuny opened a new pull request, #7187:
URL: https://github.com/apache/rocketmq-dashboard/pull/7187
### Which Issue(s) This PR Fixes
Fixes #7186
### Brief Description
Keep alert-rule imports owned by the keyed domain page that started them. A pending File.text() currently survives page departure and can dispatch an import into the old domain. Read/API outcomes can also show global success/error messages after departure.
Capture a monotonic page generation and check it after file reading and the import request, including error and loading-state continuations. Same-domain navigation preserves the current import. Already-dispatched backend writes are not cancelled or rolled back. Export, APIs, payload validation and mutation serialization are unchanged.
This is a narrow continuation of the page ownership established by merged #6190, not a duplicate of #6454's repeat-submit locks or #6889's export partitioning.
### How Did You Test This Change?
Added 11 real-page tests using React Router and AntD controls, with File.text/API promises deferred at the boundaries:
- Pending file success/error after domain navigation and full unmount.
- API success/failure after domain navigation and full unmount.
- Leaving and returning to the same domain does not revive an old read.
- StrictMode permits an active import and another selection of the same file after completion.
- Same-domain query navigation preserves the pending import.
The exact final suite with a nonempty native-rule transfer produces **9 failures and 2 passing controls** against unchanged production at 127c47b06a268cc74224d5f34c56ec7c36ac0d55. With the fix:
- `npx vitest run src/pages/ops/__tests__/AlertsPage.test.tsx src/pages/ops/__tests__/alertRulePayload.test.ts --maxWorkers=1`: **54 passed**.
- `npx tsc -b --force`: passed.
- Changed-file ESLint: zero errors, five existing warnings in alerts.tsx.
- Changed-file Prettier: passed.
- `npm run build`: passed, including distribution license check (132 components, 139 license files).
No live alert rules were imported. Full frontend/backend suites were not run locally; CI remains pending. The diff was independently reviewed. AI assistance was used.
### Checklist
- [x] One coherent change; no unrelated modifications.
- [x] Conventional Commit subject.
- [x] Regression tests added; original assertions preserved.
- [x] No new UI text or source files; existing license headers preserved.
- [ ] Full CI completed (pending).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): discard imports from abandoned domain pages [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #7187:
URL: https://github.com/apache/rocketmq-dashboard/pull/7187#issuecomment-6283249096
@lizhimins Could you review this small, CI-green shortlist when you have a chance? Grouping the older fixes and newer page-lifetime fixes here instead of pinging each PR:
- #6763: collision-free consumer progress keys (2 files; head `0f186f0`).
- #6744: refresh the current LiteTopic query after TTL updates (2 files; `55f7b87`).
- #6764: require a loaded settings baseline before saving (`d2e1683`).
- #7187: discard abandoned alert imports (2 files; `130901d`; 54 focused local tests).
- #7154: consumer/topic confirmation ownership (`cfb2a87`; 210 focused local tests).
All five are Ready for review, conflict-free, and their current-head CI runs passed when checked today. The first three have been open since October 15; the last two are newer. Each PR includes regression evidence and validation limits. Could you start with the smaller two-file changes and flag anything still blocking review? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): discard imports from abandoned domain pages [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #7187: fix(alerts): discard imports from abandoned domain pages
URL: https://github.com/apache/rocketmq-dashboard/pull/7187
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): discard imports from abandoned domain pages [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #7187:
URL: https://github.com/apache/rocketmq-dashboard/pull/7187#issuecomment-6314066269
@lizhimins A short update to the shortlist above, kept in this thread to avoid separate pings:
- #6744 has been consolidated into #6745, covering both current topic queries and maintenance pagination after delayed writes. Please use #6745 (`bce99bf`) instead; [current-head CI](https://github.com/apache/rocketmq-dashboard/actions/runs/39415441232) passed.
- #6648 (`3a2e5e9`) is also awaiting re-review: the workflow changes and duplicate cleanup were removed after #6676. The remaining two-file diff is environment restoration after extraction failure plus offline regressions; [CI](https://github.com/apache/rocketmq-dashboard/actions/runs/38733428330) passed all five jobs.
- #5255 (`af9c528`) retains the requested startup/shutdown coordination, one-second failure backoff, and removal of the redundant started flag. Its [current-head CI](https://github.com/apache/rocketmq-dashboard/actions/runs/38444063676) now passed all five jobs, superseding the older failed-run status in the discussion.
- #6654 (`d18e12a`) preserves measured aggregate backlog in health diagnostics when queue observations are absent or partial; [CI](https://github.com/apache/rocketmq-dashboard/actions/runs/38545841541) passed all five jobs.
These four are still open, Ready for review and conflict-free when rechecked on October 21. Could you revisit the requested changes on #6648/#5255 and flag any remaining blockers? The other four entries in the earlier shortlist are unchanged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(alerts): discard imports from abandoned domain pages [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #7187:
URL: https://github.com/apache/rocketmq-dashboard/pull/7187#issuecomment-6484193393
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org