You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/11/28 21:33:59 UTC
[kudu-CR] tools: expose fault tolerant scans to scanner tool
Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14812
Change subject: tools: expose fault tolerant scans to scanner tool
......................................................................
tools: expose fault tolerant scans to scanner tool
I found myself wanting to benchmark fault tolerant scans, so I thought
it was appropriate to add it to the CLI tool.
Now the following are available:
$ kudu table scan master.server.com default.table --fault_tolerant
$ kudu perf table_scan master.server.com default.table --fault_tolerant
Change-Id: I19dcee286a30b3d008df30a3af57982ea44298d0
---
M src/kudu/tools/table_scanner.cc
M src/kudu/tools/tool_action_perf.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/14812/1
--
To view, visit http://gerrit.cloudera.org:8080/14812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I19dcee286a30b3d008df30a3af57982ea44298d0
Gerrit-Change-Number: 14812
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
[kudu-CR] tools: expose fault tolerant scans to scanner tool
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14812 )
Change subject: tools: expose fault tolerant scans to scanner tool
......................................................................
Patch Set 1:
(1 comment)
Maybe a new unit test?
http://gerrit.cloudera.org:8080/#/c/14812/1/src/kudu/tools/tool_action_perf.cc
File src/kudu/tools/tool_action_perf.cc:
http://gerrit.cloudera.org:8080/#/c/14812/1/src/kudu/tools/tool_action_perf.cc@884
PS1, Line 884: .AddOptionalParameter("ordered_scan")
Not sure it's worth using both FT and ORDERED terminology. I know this is a fundamentally different approach (i.e. it's a client-less scan), but do you think we should pretend this is also FT?
--
To view, visit http://gerrit.cloudera.org:8080/14812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I19dcee286a30b3d008df30a3af57982ea44298d0
Gerrit-Change-Number: 14812
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2019 05:15:11 +0000
Gerrit-HasComments: Yes